Meh, it's not a security issue, so these are just sane defaults IMO.


On Thu, Apr 24, 2014 at 6:20 PM, Paul Kehrer <notifications@github.com>wrote:

> In cryptography/hazmat/bindings/commoncrypto/binding.py:
>
> > @@ -42,8 +42,15 @@ def _ensure_ffi_initialized(cls):
> >          if cls.ffi is not None and cls.lib is not None:
> >              return
> >
> > -        cls.ffi, cls.lib = build_ffi(cls._module_prefix, cls._modules,
> > -                                     "", "", [])
> > +        cls.ffi, cls.lib = build_ffi(
> > +            module_prefix=cls._module_prefix,
> > +            modules=cls._modules,
> > +            pre_include="",
> > +            post_include="",
> > +            libraries=[],
> > +            extra_compile_args=[],
> > +            extra_link_args=[]
>
> I'm fine with that. I didn't know how explicit we wanted to be since this
> is about as deep as you can get in our bindings.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/965/files#r11980195>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084