With a proper interface, it will not complexify the code, it is on my list,
but fixing and cleaning incorrect behaviors is more useful at the moment.
On May 31, 2014 4:26 AM, "Markus Wick" <notifications@github.com> wrote:

> In Source/Core/VideoCommon/ConstantManager.h:
>
> >  struct VertexShaderConstants
> >  {
> >  	float4 posnormalmatrix[6];
> >  	float4 projection[4];
> >  	int4 materials[4];
> > -	int4 light_colors[8]; // 8 lights
> > -	float4 lights[32]; // 8 lights * 4 parameters
> > +	struct Light
>
> I agree, packing is faster. I've talked about clean code as easy to
> understand. As you've told on irc, constant updating usually isn't the
> bottleneck, so should we include such optimizations which increase the
> complexity of the code?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dolphin-emu/dolphin/pull/439/files#r13258839>.
>