On Sun, Feb 9, 2014 at 10:10 PM, Joseph Magen <notifications@github.com>wrote:

> In app/helpers/puppetclasses_and_environments_helper.rb:
>
> > @@ -19,6 +19,11 @@ def import_proxy_select hash
> >      )
> >    end
> >
> > +  def import_proxy_link hash, env
> > +    proxy = SmartProxy.puppet_proxies.
> first
> > +    display_link_if_authorized(_("Import %{env} from %{proxy}") % {:env => env, :proxy => proxy.name}, hash.merge(:proxy => proxy, :env => env))
>
> @neoseele <https://github.com/neoseele>, I'm not sure that {%env} is
> really needed. The button label "Import from %{proxy}" should be fine.
> Similarly, we we have "Edit" and "Delete" on each row without saying "Edit
> environment XYZ" or "Delete environment XYZ"
>
or just name it "Import class" :)


> --
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/1215/files#r9568602>
> .
>



-- 
Neil

Oh gods, why me?