add unified interface for accessing file system

**please review**
OK, I'd like to understand this as well, all the pros and cons of the current approach and what alternative we have, with its pros and cons.  Cosmin, when you come back from OOPSLA, let us get together in a room with Dwight and discuss this.

Thanks,
Grigore


________________________________
From: Cosmin Radoi [notifications@github.com]
Sent: Tuesday, October 21, 2014 11:22 AM
To: kframework/k
Subject: Re: [k] add unified interface for accessing file system (#1070)


In java-backend/src/main/java/org/kframework/backend/java/symbolic/JavaSymbolicBackend.java:

> @@ -69,8 +71,7 @@ public Definition lastStep(Definition javaDef) {
>
>          definition.setIndex(index.get());
>
> -        loader.saveOrDie(new File(context.kompiled,
> -                JavaSymbolicBackend.DEFINITION_FILENAME).toString(),
> +        loader.saveOrDie(files.resolveKompiled(JavaSymbolicBackend.DEFINITION_FILENAME),


This is not about feelings. It's about engineering.

creating the monolithic dependency is the entire purpose of
this code review

For what you gain out of it, this is bad engineering.

—
Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/1070/files#r19159572>.