worked on P and S controller in api