will do, nice working with you


On 14 March 2014 16:21, Bozhidar Batsov <notifications@github.com> wrote:

> In lib/rubocop/options.rb:
>
> > @@ -9,6 +9,7 @@ class Options
> >
> >      def initialize
> >        @options = {}
> > +      @incompat = []
>
> Increase the allowed class length in the project's own rubocop.yml.
> ... <#144c166484923b63_>
> -- Cheers, Bozhidar
> On Friday, March 14, 2014 at 6:19 PM, jkogara wrote: In
> lib/rubocop/options.rb: > @@ -9,6 +9,7 @@ class Options > > def initialize
> > @options <https://github.com/options> = {} > + @incompat = [] It's
> currently failing Travis on Options class length definition, that ok or
> should I look at refactoring? ... (#) On 14 March 2014 16:13, Bozhidar Batsov
> <notifications@github.com (mailto:notifications@github.com)> wrote: In
> lib/rubocop/options.rb: > @@ -9,6 +9,7 @@ class Options > > def initialize
> > @options <https://github.com/options> (https://github.com/options) = {}
> > + @incompat = [] Yeah, that's exactly what I had in mind. Squash the
> related commits together, add a changelog entry and we're good to go. ...
> <#144c15e3df379ad9_> -- Cheers, Bozhidar On Friday, March 14, 2014 at 6:04
> PM, jkogara wrote: In lib/rubocop/options.rb: > @@ -9,6 +9,7 @@ class
> Options > > def initialize > @options <https://github.com/options> (
> https://github.com/options) <https://github.com/options> = {} > +
> @incompat = [] This better? jkogara@792e999<https://github.com/jkogara/rubocop/commit/792e999>(
> https://github.com/jkogara/rubocop/commit/792e999)<https://github.com/jkogara/rubocop/commit/792e999>(
> https://github.com/jkogara/rubocop/commit/792e999908a3617fb7c3b83e71a72b4f2516db10)
> -- Reply to this email directly or view it on GitHub (
> https://github.com/bbatsov/rubocop/pull/870/files#r10614002). -- Reply to
> this email directly or view it on GitHub<
> https://github.com/bbatsov/rubocop/pull/870/files#r10614419> . -- Reply to
> this email directly or view it on GitHub (
> https://github.com/bbatsov/rubocop/pull/870/files#r10614728).
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/bbatsov/rubocop/pull/870/files#r10614826>
> .
>