expanding on ethernet

expanded ethernet mac/phy, more configurability. replaced ethernet.o by the ethernet/ mac/phy files in f1/Makefile.
+1 from me on descriptive names

On Wed, Dec 17, 2014 at 1:34 PM, Frantisek Burian <notifications@github.com>
wrote:
>
> In lib/ethernet/mac_stm32fxx7.c
> <https://github.com/libopencm3/libopencm3/pull/377#discussion-diff-22006213>
> :
>
> > +/*---------------------------------------------------------------------------*/
> > +/** @brief Enable Fast Ethernet feature
> > + *
> > + * This function will indicate the speed in Fast Ethernet (MII) mode
> > + * This will result in Fast Ethernet (MII) mode @ 100Mbit/s
> > + */
> > +void eth_mac_fes_enable(void)
> > +{
> > +	ETH_MACCR |= ETH_MACCR_FES;
> > +}
> > +
> > +/*---------------------------------------------------------------------------*/
> > +/** @brief Disable Fast Ethernet feature
> > + *
> > + * This function will indicate the speed in Fast Ethernet (MII) mode
> > + * This will result in Fast Ethernet (MII) mode @ 10Mbit/s
>
> I'm voting for
>
> eth_mac_set_100Mbits()
> eth_mac_set_10Mbits()
>
> the name of function should be self descriptive, so it will not need to
> read entire peripheral documentation what the author of the function really
> mean.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libopencm3/libopencm3/pull/377/files#r22006213>.
>