Fixing BCWarehouse::all()

Calling all() on BCWarehouse now returns the array of all BCs added
to the warehouse.

Refs #3692
Merge pull request #4354 from andrsd/bc-warehouse-all

Fixing BCWarehouse::all()