It is safer here. The dependency to BuildFlow is optional, the class can still be loaded. If I put it into BuildFlow I would need to create a hard dependency on Build Failure Analyzer, else the extension would thorw a class not found on loading the plugin.

The best way would be to refactor this functionality into a core extension point in Jenkins (or a separate plugin). Then all plugins could provide their own extensions.

Stephan

----- Ursprüngliche Mail -----
Von: "Robert Sandell" <notifications@github.com>
An: "jenkinsci/build-failure-analyzer-plugin" <build-failure-analyzer-plugin@noreply.github.com>
CC: "Stephan Pauxberger" <stephan@eucodos.de>
Gesendet: Dienstag, 3. Juni 2014 11:14:38
Betreff: Re: [build-failure-analyzer-plugin] BuildFlow Dependencies And Nested Failure Causes in Gerrit (#18)

In
src/main/java/com/sonyericsson/jenkins/plugins/bfa/model/dbf/BuildFlowDBF.java:
> +import hudson.model.AbstractBuild;
> + +import java.util.ArrayList;
> +import java.util.List;
> +import java.util.Set;
> +import java.util.concurrent.ExecutionException;
> + +
> +/** + * Get downstream builds for Build Flows.
> + * <p/>
> + *
> + * @author Stephan Pauxberger
> + */
> +@Extension +public class BuildFlowDBF extends DownstreamBuildFinder {

Maybe this class would be more suitable implemented in the build flow
plugin.

—
Reply to this email directly or view it on GitHub .