2010-03-27  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Fraser.

        [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.

        https://bugs.webkit.org/show_bug.cgi?id=36701

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance): Add onSetWindow.
        (webkit_test_plugin_destroy_instance): Add onSetWindow.
        (webkit_test_plugin_set_window): Add onSetWindow.
        * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
        (NPP_New): Add onSetWindow.
        (NPP_Destroy): Add onSetWindow.
        (NPP_SetWindow): Add onSetWindow.

2010-03-27  Robert Hogan  <robert@webkit.org>

        Unreviewed skip failing test.

        [Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702

        https://bugs.webkit.org/show_bug.cgi?id=36701

        * platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the newly-added test to not trip over a bug that causes some subsequent tests to fail.

Rubber-stamped by Dan Bernstein.

* fast/dom/script-tests/setPrimitiveValue-exceptions.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-26  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Converge Inspector ids to be long, not ints
        https://bugs.webkit.org/show_bug.cgi?id=36706

          Part 1: Converge on `long` for callIds, nodeIds, and other Ids.

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        The test-webkitpy script now automatically detects all unit-test
        files in webkitpy/.  This lets us eliminate the need to have and
        maintain all of the unittests.py files.

        https://bugs.webkit.org/show_bug.cgi?id=36591

        * Scripts/test-webkitpy:
          - Replaced the "from webkitpy.unittests import *" with a call
            to webkitpy.test.main.Tester().run_tests().

        * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
          - Required file for the new webkitpy/test/ directory.

        * Scripts/webkitpy/test/main.py: Added.
          - Added a Tester class that contains the following methods:
            - _find_unittest_files() to detect all the unit-test files.
            - _modules_from_paths() to convert the paths to the unit-test
              files to fully-qualified module names.
            - run_tests() which calls the above two methods and then passes
              the module names to Python's unittest module.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rubber-stamped by Adam Barth.

Fixed the name of a unit test file in webkitpy.

* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.

LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/invalid-import-rule-insertion.html:
* http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
* http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
* http/tests/security/cross-origin-css-expected.txt:
* http/tests/security/cross-origin-css-in-xml-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Add a CR after printing didFinishDocumentLoadForFrame

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadFinished):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
More updated results for r56673.

* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Dmitry Gorbik  <socket.h@gmail.com>

        Reviewed by Pavel Feldman.

        Fix the regression caused by r28078: a global variable
        definition masks a local one in an inspector console
        https://bugs.webkit.org/show_bug.cgi?id=32442

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        In webkitpy/, deleted the /unittests.py files since test-webkitpy
        now auto-detects all *_unittest.py files.

        https://bugs.webkit.org/show_bug.cgi?id=36712

        * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
        * Scripts/webkitpy/common/system/unittests.py: Removed.
        * Scripts/webkitpy/common/thread/unittests.py: Removed.
        * Scripts/webkitpy/common/unittests.py: Removed.
        * Scripts/webkitpy/python24/unittests.py: Removed.
        * Scripts/webkitpy/style/unittests.py: Removed.
        * Scripts/webkitpy/tool/unittests.py: Removed.
        * Scripts/webkitpy/unittests.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Use WebKitClient to instantiate WebGraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=36669

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didStartProvisionalLoadForFrame in the callback of
        notify::load-status property change notification

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webInspectorCloseWindow):
        (webInspectorInspectWebView):
        (createWebView): added connection to notify::load-status and
        signal callback

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didCommitLoadForFrame in the callback of signal::load-committed

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadCommitted):
        (createWebView): added connection to sinal::load-committed and
        signal callback

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Removed 5 http/history tests from Skipped file

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * platform/gtk/Skipped:
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        FrameLoader emits onload-event when handling
        dispatchDidHandleOnloadEvents

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
        implemented, now it emits onload-event signal
        * webkit/webkitwebview.cpp: added onload-event signal
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didHandleOnloadEventsForFrame in the callback of
        onload-event signal comming from frame loader

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewOnloadEvent):
        (createWebView): added connection to signal::onload-event and
        signal callback

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Changed check-webkit-style to convert paths to paths relative to
the checkout root when invoking check-webkit-style with path
arguments.  Also added warning messages where appropriate.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35498

Converting paths to paths relative to the checkout root ensures
that style checking will behave as expected (since path-specific
rules assume input paths are relative to a source root).

* Scripts/check-webkit-style:
  - Added debug logging of whether the current directory was found
    to be in a WebKit checkout.
  - Added the found_checkout parameter to the call to parser.parse().
  - Renamed the files variable to paths.
  - Added a call to change_directory() prior to checking style.

* Scripts/webkitpy/style/checker.py:
  - For StyleChecker.check_file():
    - Updated the docstring.
    - Added two log messages.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated a call to parser.parse() with the found_checkout parameter.

* Scripts/webkitpy/style/main.py: Added.
  - Added a new file so the code in this patch could be unit-tested,
    as opposed to adding new code to check-webkit-style.
  - Added the method _rel_path() as a substitute for os.path.relpath(),
    which is available only in Python 2.6.
  - Added the method change_directory(), which contains most of the
    new functionality in this patch.

* Scripts/webkitpy/style/main_unittest.py: Added.
  - Added RelPathTest to test main._rel_path().
  - Added ChangeDirectoryTest to test main.change_directory().

* Scripts/webkitpy/style/optparser.py:
  - Updated check-webkit-style's usage string.
  - For the ArgumentParser.parse() method:
    - Added a found_checkout parameter.
    - Renamed filenames to paths.
    - Added logic so that an error is raised if no paths are passed
      if found_checkout is False.

* Scripts/webkitpy/style/optparser_unittest.py:
  - Updated the ArgumentParser.parse() unit tests to include
    coverage for the new found_checkout parameter.

* Scripts/webkitpy/style/unittests.py:
  - Added an import statement for main_unittest.

* Scripts/webkitpy/style_references.py:
  - Renamed SimpleScm to WebKitCheckout.
  - Added a detect_checkout() function to allow returning None
    instead of a WebKitCheckout instance if no checkout is found.
  - Renamed checkout_root to root_path.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

        Allow editing an Element's Tag Name by double clicking
        on the tag name in the Element's Tree Hierarchy.

          The usual asynchronous InspectorBackend, InspectorDOMAgent, InspectorFrontend flow.

        * inspector/InspectorBackend.cpp: moved DOM manipulation to InspectorDOMAgent
        (WebCore::InspectorBackend::removeNode):
        (WebCore::InspectorBackend::changeTagName):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::removeNode):
        (WebCore::InspectorDOMAgent::changeTagName):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didChangeTagName):
        * inspector/InspectorFrontend.h:

        * inspector/front-end/DOMAgent.js:

          Handle the UI for editing an Element's tag name.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): allow editing from double click.
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.keyupListener): update the closing tag
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingComitted): remove extra listener and commit
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingCancelled): remove extra listener and cancel
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.cancel):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.editTagNameCallback):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
        (WebInspector.ElementsTreeElement.prototype._distinctClosingTagElement): get the closing tag for an opening tag
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): wrap the tagName in span.webkit-html-tag-name

          Miscellaneous updates.

        * inspector/front-end/treeoutline.js: fixed a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

        Allow tabbing back and forth between the tag name and element
        attributes when editing. Also, fixed a number of minor issues with
        editing attributes and tabbing.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName): find the tag name if it wasn't provided.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): fix tabbing issues, enable tab to tag name.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): cleanup styles when tabbing.
        * inspector/front-end/inspector.css: do not display <br>s while editing

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-28  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: Timing functions don't work with transitions
        https://bugs.webkit.org/show_bug.cgi?id=36589

        If the animation value doesn't have timing function set, we need to
        use the animation's timing function.

        Fixed also a bug in passing the duration to solveCubicBezierFunction.
        The duration was divided two times by 1000 and meanwhile casted to int.
        It needs to be kept as double and divided by 1000 only once.

        Test case: https://bugs.webkit.org/attachment.cgi?id=51619

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::applyTimingFunction):
        (WebCore::AnimationQt:::AnimationQtBase):
        (WebCore::AnimationQt::updateCurrentTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-28  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        QScriptEngine API was enriched by globalObject() method
        which give an access to the global object.

        [Qt] QScriptEngine doesn't give an access to global object
        https://bugs.webkit.org/show_bug.cgi?id=36603

        * qt/api/qscriptengine.cpp:
        (QScriptEngine::globalObject):
        * qt/api/qscriptengine.h:
        * qt/api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::globalObject):
        * qt/api/qscriptengine_p.h:
        * qt/tests/qscriptengine/tst_qscriptengine.cpp:
        (tst_QScriptEngine::globalObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-03-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

          Ensure blacklisting happens by checking it in _startEditingTagName
          instead of all the possible entry points.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): don't check blacklist here.
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName): check blacklist here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56687 268f45cc-cd09-0410-ab3c-d52691b4dbfc