Okay - so, what if we move filterParams to both push/pull as well. For now,
of course, we'll just put it in pull since we don't yet support filtered
push replication.

Then, all that is left in the base class are the error codes,
-dictionaryForReplicatorDocument and -validateRemoteDatastoreURL





From:	Mike Rhodes <notifications@github.com>
To:	cloudant/CDTDatastore <CDTDatastore@noreply.github.com>
Cc:	Adam Cox <gadamc@cloudant.com>
Date:	05/29/2014 03:35
Subject:	Re: [CDTDatastore] Adds support for filtered pull replication.
            (#23)



In Classes/common/CDTReplicator/CDTAbstractReplication.m:


> + This method sets all of the common replication parameters. The
subclasses,
> + CDTPushReplication and CDTPullReplication add source, target and
filter.
> + */
> +-(NSDictionary*) dictionaryForReplicatorDocument:(NSError *
__autoreleasing*)error
> +{
> +    return nil;
> +}
> +
> +
> +- (NSString *)description
> +{
> +    return [NSString stringWithFormat:@"Replicator Doc: %@",
> +            [self dictionaryForReplicatorDocument:nil]];
> +}
> +
> +-(BOOL)validateRemoteDatastoreURL:(NSError * __autoreleasing*)error



As mentioned, change this to take in the URL to validate.


Also, though it won't be relevant once you pass in the URL, constantly
referring to the URL as self.remoteDatastore is both expensive to execute
and tiring to read. It should've been pulled into a variable at the top of
the method.


—
Reply to this email directly or view it on GitHub.