Absolute URLs for links appearing in feed

note that this changes the oft-used byline()

http://code.google.com/p/otwarchive/issues/detail?id=2954
Still around but lacking home internet ;_; I'll give it a poke when I get
that sorted.


On 15 June 2014 09:51, Cristina <notifications@github.com> wrote:

> In app/helpers/series_helper.rb:
>
> > @@ -33,7 +33,7 @@ def series_list_for_feeds(work)
> >        list = []
> >        for s in series
> >          list << "Part #{s.serial_works.where(:work_id => work.id).select(:position).first.position} of
> > -#{link_to(s.title, s)}"
> > +#{link_to(s.title, series_url(s))}"
>
> Much-belated review /o\
>
> I don't know if you're still around, @openendings
> <https://github.com/openendings>, but if you are and still willing to
> work on this:
>
> I would prefer if this was put on the same line as the text above. Also,
> given that we're nearing the translation stage, if this was turned into a
> translation string with interpolated variables, like so:
> ts("Part %{serial_index} of %{link_to_series}", serial_index:
> s.serial_works.where(work_id: work.id).select(:position).first.position,
> link_to_series: link_to(s.title, series_url(s)))
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/otwcode/otwarchive/pull/736/files#r13783448>.
>