(PUP-3009) Add error handling to PMT module downloads

Before this PMT would not check if the module download request
succeeded before trying install the module. This causes informative
errors from forge to be hidden by an error about the checksum of the
download not matching. After this PMT will only move forward with module
installation if a 200 is received from forge otherwise it will display
the error returned by forge.
(PUP-2967) Remove the deprecated recurse => inf

The use of 'inf' as a synonym for 'true' made sense when the 'recurse'
parameter could take integer values, instead of using 'recurselimit'.
But integer values for 'recurse' are no longer valid, so 'inf' makes
no sense.
Merge pull request #2892 from vrthra/rubocop/puppet-4/andor-fix

(PUP-2950) rubocop - Style/AndOR enabled for pops
Merge pull request #2941 from adreyer/PUP-3009

(PUP-3009) Add error handling to PMT module downloads
Revert "(maint) Use public API when testing binary file #save"

This reverts commit 133c0b8009a48eef77d68c0bd8d5f79c930dab50.
Revert "Merge branch 'pull-2938'"

This reverts commit 1a428b92c900e84d9faa5d0aaa1a32f3c0b1d42b, reversing
changes made to cb26e23706b76e44544c14f4c921885f17dccbb3.
Merge branch 'revert/master/pup-2946-windows-specs'

We're getting spec failures on Windows running Ruby 2.0, we have to
revert this and try again so the build doesn't stay red.
Merge branch 'master' into puppet-4
(PUP-3019) Make PMT check for string status codes when downloading

Previously PMT was checking for integer status codes when downloading
modules. This results in all module downloads failing. After this PMT
will check for string status codes when downloading modules.
Merge pull request #2945 from adreyer/PUP-3019

(PUP-3019) Make PMT check for string status codes when downloading
Merge pull request #2940 from kylog/issue/pup-2967/remove-recurse-inf

(PUP-2967) Remove the deprecated recurse => inf
Merge branch 'master' into puppet-4
! xxx to !xxx
autocorrect:rubocop
not xxx to !xxx
andor