Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables.
- Add parenthensis around return values

Partial-Bug: #1271535
Change-Id: I1aa473e406059fec66b0b2c9a307e8eeb41b0996
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace. We also fix a test where node isn't being
converged after setting attributes and import chefspec/berksfile in
spec/spec_helper.rb so we can run rspec outside of strainer.

Change-Id: I7e27a60c4245de2e4d8033439a2429d89006a356
Implements: blueprint clean-up-attr-for-mq-and-db
Update attributes to be rubocop compliant

- Update .rubocop.yml file to correctly check attributes
- Update attributes/default.rb to be rubocop compliant

Addresses: blueprint rubocop-for-network
Change-Id: I04ff5003d0e916369d58b05d19a6f16252f3604b
Update spec files to be rubocop compliant

- Update .rubocop.yml to include spec/**
- Update spec files to be rubocop compliant
- Inlcude 'chefspec/berkshelf' in spec_helper.rb for ease of use

Change-Id: Ief01cc34cc4f9f04e6ba6437f67bfd347975c3a8
Addresses: blueprint rubocop-for-network
Merge "Update attributes to be rubocop compliant"
Merge "Update spec files to be rubocop compliant"
Update recipes to be rubocop compliant

- Adjust .rubocop.yml to include recipes/**
- Complete rubocop compliancy for recipes/*.rb

Change-Id: Id5b5ac26f74046085e3f07d1696189061a03ee2e
Addresses: blueprint rubocop-for-network
Remove unneeded and redundant rhel setup scripts

3 scripts called in rhel/centos/fedora case
- neutron-dhcp-setup
- neutron-l3-setup
- neturon-node-setup (openvswitch)

They set config options that are already handled, for example:
messaging - rpc_backend and qpid_hostname.
keystone - auth_url, admin_username, admin_password, admin_tenant_name.
Testing confirmed no differences in etc/neutron config tree.

Addresses: blueprint centos-rhel-for-network

Change-Id: I56f8482d95908d41e0b33552017166a4e1105177
Merge "Remove unneeded and redundant rhel setup scripts"