refactoring of line shape is done