refactoring string generator
refactoring string generator