working on xml but not done yet