made model_params more generic