Ok, 2048 seems fine then.


On Sun, Feb 23, 2014 at 7:18 PM, Paul Kehrer <notifications@github.com>wrote:

> In docs/hazmat/primitives/asymmetric/rsa.rst:
>
> > +            :class:`~cryptography.hazmat.primitives.interfaces.HashAlgorithm`
> > +            provider.
> > +
> > +        :param backend: A
> > +            :class:`~cryptography.hazmat.backends.interfaces.RSABackend`
> > +            provider.
> > +
> > +        :returns:
> > +            :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricSignatureContext`
> > +
> > +        .. doctest::
> > +
> > +            >>> from cryptography.hazmat.backends import default_backend
> > +            >>> from cryptography.hazmat.primitives import hashes
> > +            >>> from cryptography.hazmat.primitives.asymmetric import rsa, padding
> > +            >>> private_key = rsa.RSAPrivateKey.generate(65537, 2048, default_backend())
>
> We can move to 4096. It’ll take ~7-15s to generate the key for the test
> then. I’d suggest we stay at 2048 (as that is still considered the best
> practice with a good security margin and acceptable performance).
> … <#14461792771f9a52_>
> On Sunday, February 23, 2014 at 7:15 PM, Alex Gaynor wrote: In
> docs/hazmat/primitives/asymmetric/rsa.rst: > +
> :class:`~cryptography.hazmat.primitives.interfaces.HashAlgorithm` > +
> provider. > + > + :param backend: A > +
> :class:`~cryptography.hazmat.backends.interfaces.RSABackend` > + provider.
> > + > + :returns: > +
> :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricSignatureContext`
> > + > + .. doctest:: > + > + >>> from cryptography.hazmat.backends import
> default_backend > + >>> from cryptography.hazmat.primitives import hashes >
> + >>> from cryptography.hazmat.primitives.asymmetric import rsa, padding >
> + >>> private_key = rsa.RSAPrivateKey.generate(65537, 2048,
> default_backend()) keyword args please, and should we maybe use 4096? Does
> it make doctests slow? — Reply to this email directly or view it on GitHub (
> https://github.com/pyca/cryptography/pull/673/files#r9979220).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/673/files#r9979258>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084