Catch correct error and disable warning.

If there are not enough fields, a ValueError is raised
because the unpacking of values does not succeed.

Disable the warning because rest is serving a legitimate function as a place
holder.

Signed-off-by: mulhern <amulhern@redhat.com>
Give abstract method the same signature as its overriding methods.

ABC metaclass mechanisms do not check the signature of a method, only
its name, so this went undetected. It was also benign.

Signed-off-by: mulhern <amulhern@redhat.com>
Spell parameter self correctly

Since self was never used, this misspelling was benign.

Signed-off-by: mulhern <amulhern@redhat.com>
Put a field and a method in the base class

* Add an abstract method for _labelstrRegex
* Stick field _name in the base class (can't abstractify it)

All subclasses already override _labelstrRegex, so these errors were benign.

Signed-off-by: mulhern <amulhern@redhat.com>
Get rid of unnecessary pass statements

Signed-off-by: mulhern <amulhern@redhat.com>
Don't comment out function headers but leave their bodies uncommented

Instead, delete the functions entirely.

Signed-off-by: mulhern <amulhern@redhat.com>
Delete method-local pruneFile function.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove unused assignment to boot.

boot is not used anywhere in the method below and I do not believe that it
is global. So, the only effect of this change would be that if
self.bootDevice raises an exception that is not in
(DeviceError, AttributeError) that exception will no longer be propagated.
But it seems unlikely that such an exception was being raised anyway.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove some unused exception names.

Where the code is:

except <SomeException> as <var>:
    <some code>

and <var> is never used, change to:

except <SomeException>:
    <some code>

Signed-off-by: mulhern <amulhern@redhat.com>
Replace with a semantically equivalent chunk.

This was motivated by a complaint about unused variable path.

Signed-off-by: mulhern <amulhern@redhat.com>