Remove Docker-in-Docker from builds

Remove all traces of Docker-in-Docker from builds. The rationale is explained
generally in the `docs/builds.md` file. In short, Docker-in-Docker isn't secure
or stable for production, and there's no indication it will be in the forseeable
future. The codebase can be simplified by eliminating it, and our focus and
efforts can shift to solving the remaining issues with host Docker access.
This seems to me to fall into the category of things which should be
parameters to the build controller. @smarterclayton does this pass the
threshold for adding a new cli flag?

On Friday, September 19, 2014, Michal Fojtik <notifications@github.com>
wrote:

> In pkg/build/strategy/util.go:
>
> >
> > -		podSpec.DesiredState.Manifest.Volumes = append(podSpec.DesiredState.Manifest.Volumes,
> > -			dockerSocketVolume)
> > -		podSpec.DesiredState.Manifest.Containers[0].VolumeMounts =
> > -			append(podSpec.DesiredState.Manifest.Containers[0].VolumeMounts,
> > -				dockerSocketVolumeMount)
> > -	} else {
> > -		podSpec.DesiredState.Manifest.Containers[0].Privileged = true
> > +	dockerSocketVolumeMount := api.VolumeMount{
> > +		Name:      "docker-socket",
> > +		MountPath: "/var/run/docker.sock",
>
> Shouldn't this be configurable?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openshift/origin/pull/111/files#r17789238>.
>