change some constants to enum