RSpec tests

- The added RSpec tests are both from transferring from the rake tests and new tests.
- removed the unused Assignment#submission_by(user) method
The reason I went with "nil" is to be explicit with the return value. I wanted it to be clear that it's not an empty array being returned and other words I considered like "nothing" didn't make sense.