Bug 1061814

Hi,
It’s not my piece of code, (Daniel Marecik did this) but thank you for information:)

All the best,
Wojtek Lakomy

From: Zibi Braniecki [mailto:notifications@github.com]
Sent: Friday, September 12, 2014 7:35 PM
To: mozilla-b2g/gaia
Cc: Lakomy, Wojciech (REC)
Subject: Re: [gaia] Bug 1061814 (#24012)


In dev_apps/privacy-panel/js/custom_location_panel.js:

> +

> +  toggleLatitude: function(event) {

> +    this.settings.latitude = event.target.value;

> +    this.changedParameters();

> +  },

> +

> +  updateCountriesList: function() {

> +    this.cities = this.countriesAndCities[this.settings.country];

> +

> +    this.$countries.innerHTML = '';

> +

> +    for (var countryName in this.countriesAndCities) {

> +      if (this.countriesAndCities.hasOwnProperty(countryName)) {

> +        var option = document.createElement('option');

> +        option.value = countryName;

> +        option.text = this.l10n.get(countryName);

please, use option.setAttribute('data-l10n-id', countryName); instead

—
Reply to this email directly or view it on GitHub<https://github.com/mozilla-b2g/gaia/pull/24012/files#r17491551>.