Add info for reviewers of outside developer commits.

Add the start of a section that talks about the responsibilities of
Chapel core team reviewers of outside developers' commits.

While here, fix a typo in a cross-ref.
Found and fixed a bug in the glob() routine

It turns out that when I moved Tim's glob() routine into the
Filerator.chpl module, I changed a c_int return type of
chpl_glob_num() to a size_t to better reflect the C interface.
However, in doing so, I also introduced an error because we iterated
over the range:

     0..chpl_glob_num(...)-1

which, for a glob() call with no matches, resulted in:

     0..0:uint(64)-1

or:

     0..max(uint(64))

which is a range that we generate overflow warnings for.  In Tim's
original code, this just resulted in 0..-1 which wasn't an issue.

This commit fixes the bug by checking against '0' before entering the
loop over the range.  It also files a few test cases that exercised
the bug and updates the output of the globberator.good file to
reflect the new tests.
Merge pull request #580 from bradcray/glob-fixes

Found and fixed a bug in the glob() routine

It turns out that when I moved Tim's glob() routine into the
Filerator.chpl module, I changed a c_int return type of
chpl_glob_num() to a size_t to better reflect the C interface.
However, in doing so, I also introduced an error because we iterated
over the range:

     0..chpl_glob_num(...)-1

which, for a glob() call with no matches, resulted in:

     0..0:uint(64)-1

or:

     0..max(uint(64))

which is a range that we generate overflow warnings for.  In Tim's
original code, this just resulted in 0..-1 which wasn't an issue.

This commit fixes the bug by checking against '0' before entering the
loop over the range.  It also files a few test cases that exercised
the bug and updates the output of the globberator.good file to
reflect the new tests.
Add the '-cc' option to the aprun command.

With the aprun default of '-cc cpu', we only get kernel scheduling
affinity with a single KNC CPU.  In order to get scheduling affinity
with all of them, we need to give some other option.  The '-cc none'
we give on other Cray system compute nodes seems to work fine for
this.

While here, I also removed some trailing white space on one line.
Merge pull request #583 from gbtitus/knc-aprun-needs-cc-none

Add the '-cc' option to the aprun command.

With the aprun default of '-cc cpu', we only get kernel scheduling
affinity with a single KNC CPU. In order to get scheduling affinity
with all of them, we need to give some other option. The '-cc none'
we give on other Cray system compute nodes seems to work fine for
this.

While here, I also removed some trailing white space on one line.
SLURM doc updates
Merge pull request #585 from vasslitvinov/adjust-readmes-for-SLURM-launcher

SLURM doc updates

* Added the requirement to set CHPL_LAUNCHER_WALLTIME for slurm-gasnetrun_ibv launcher.

While there:

* Noted that CHPL_LAUNCHER gets set to none when slurm and aprun are both in user's path.

* Streamlined slurm notes.

* Tweaked the formatting of how CHPL_LAUNCHER is chosen by default.

Reviewed by Elliot.
Add a note about ugni memory registration and concurrency with slurm.
Merge pull request #587 from gbtitus/doc-slurm-ugni-mem-registration-issue

Add a note about ugni memory registration and concurrency with slurm.

Reviewed by Thomas.
Fix nondeterministic output from walkdir() by requesting sorted output
Merge pull request #590 from bradcray/fix-filerator-regression

Fix nondeterministic output from walkdir() by requesting sorted output

[trivial, not reviewed]

I forgot to request sorted output in my new test yesterday, which
resulted in nondeterministic behavior across file systems/machines.
This broken in one configuration last night (and could break in others
over time).
Minor update to reflect review feedback.
Merge pull request #522 from gbtitus/update-contrib-practice

Add info for reviewers of outside developer commits.

Add a section that talks about the responsibilities of Chapel core
team reviewers of outside developers' commits.

While here, fix a typo in a cross-ref.

Reviewed by Brad.