Class with unit tests

I worked thru the changes in the email:
cleaning up the names
removing the duplicate unittests.
Hi Sarah,

I can see what you mean.  I was thinking since all my methods deal with Dataframes, it would be good to return the histogram information in another type of pandas object, namely a Series.

The other thing is, I am kinda of pandas centric.  I am focusing most of my python learning around pandas, and the data analysis part.  I don’t really think I can compete with pure developers in python, but I can compete with scientists and engineers in using python as a tool.

Once I get this unittest thing under control, do you think I can start to contribute to the machine learning part?

cheers,
Matt




On Jul 9, 2014, at 1:53 PM, Sarah Bird <notifications@github.com> wrote:

> In ocdata_blend/tests/ColumnFeatures.py:
> 
> > +        return num_col
> > +
> > +    def get_feature_histo(var_col_list, var_df):
> > +        ## takes two variables, a list of column names and a dataframe
> > +        col_name_frequency_dict = {}
> > +
> > +        for item in var_col_list:
> > +            vc_f_item = var_df[item].value_counts()  ##value counts for item
> > +            ##print vc_f_item
> > +            length_entities_item = len(vc_f_item)  ## the length of the value counts or the number of entities for an item
> > +            ##print length_entities_item
> > +            col_name_frequency_dict[item] = length_entities_item
> > +
> > +        series_Column_Entities_Frequency_ = pd.Series(col_name_frequency_dict)
> > +
> > +        return series_Column_Entities_Frequency_
> hmmm....this returns a pandas series, i was expecting a histogram.....maybe this should return a list of lists or something? It may be better if the users of this didn't have to know / handle pandas. Happy to discuss.
> 
> —
> Reply to this email directly or view it on GitHub.
>