uptaing generic controller class