Better error messages in the most common cases of users attempting to access things they shouldn't. Better emails too.
admin area edit template
delete folder
Fix for shibboleth errors

Fixes for the following errors:

——

A NoMethodError occurred in omniauth_callbacks#shibboleth:

undefined method `confirmed_at' for nil:NilClass
app/controllers/users/omniauth_callback_controller.rb:16:in
`shibboleth'

——

An ActionView::MissingTemplate occurred in
omniauth_callbacks#shibboleth:

Missing template users/omniauth_callbacks/shibboleth,
devise/omniauth_callbacks/shibboleth, devise/shibboleth,
application/shibboleth with {:locale=>[:en], :formats=>[:html],
:handlers=>[:erb, :builder, :arb]}

——

A NoMethodError occurred in omniauth_shibboleth_request#redirect:

undefined method `wayfless_entity' for nil:NilClass
app/controllers/users/omniauth_shibboleth_request_controller.rb:6:in
`redirect'

——

Missing template error corrected by adding catch-all redirect (to root
path) at the end of the method. Undefined method for nil:NilClass
errors corrected with checks that relevant entities are not nil.
Merge pull request #58 from DigitalCurationCentre/Shibboleth-bugs

Fix for shibboleth errors
Fix for multiple redirect error in last commit
Merge pull request #59 from DigitalCurationCentre/Shibboleth-bugs

Fix for multiple redirect error in last commit
Checking shibboleth_id isn't an empty string

Deleting shibboleth_id via activeadmin leaves and empty string rather
than null. We need to check for that.
Merge pull request #60 from DigitalCurationCentre/Shibboleth-bugs

Checking shibboleth_id isn't an empty string
Avoiding conflict nonsense
Merge pull request #62 from DigitalCurationCentre/Shibboleth-bugs

Avoiding conflict nonsense
Fix for Shibboleth "visit IdP twice" bug

Authentication was occurring the first time the user selected their
institution, but they were then being redirected back to the IdP by the
“sign_in_and_redirect s_user, event: :authentication” line. The second
time they selected their institution, they were already authenticated
and were simply redirected. This fixes that, sending the user to the
root path after logging in via Shibboleth or to the edit profile page
after linking their account.
Merge pull request #63 from DigitalCurationCentre/Shibboleth-bugs

Fix for Shibboleth "visit IdP twice" bug
rails generate rspec:install
add test to ensure site is up and renders
updated Gemfile to install rspec and selenium-webdriver
add ci-reporter gem to test deployment so jenkins knows how to read rspec output
add ci-reporter to Rakefile so it knows what we're asking about
Revert "add ci-reporter to Rakefile so it knows what we're asking about"

This reverts commit d18d0c90dcc44b53288d4c2a77db3c2c5f9d0d9d.
add build task ci:setup:rspec