Yes strcasecmp would be better.
Perhaps this patch is useless if we find why the case is changing. The bug
appears when I click on a attached file on canned response edit.
Le 28 mars 2014 21:30, "Jared Hancock" <notifications@github.com> a écrit :

> In scp/file.php:
>
> > @@ -23,7 +23,7 @@
> >  //basic checks
> >  if(!$h  || strlen($h)!=64  //32*2
> >          || !($file=AttachmentFile::lookup(substr($h,0,32))) //first 32 is the file hash.
> > -        || $file->getDownloadHash() != $h) //next 32 is file id + session hash.
> > +        || strtolower($file->getDownloadHash()) != strtolower ($h)) //next 32 is file id + session hash.
>
> Should we just use strcasecmp?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/osTicket/osTicket-1.8/pull/734/files#r11084299>
> .
>