Artifacts from https://github.com/floodlight/loxigen/compare/1bfc0e32601b548d10261948f18220fd41144dd9...37b4043b8e4f08bf8ffd3b92436a09b0f2726277

Loxigen Head commit floodlight/loxigen@37b4043b8e4f08bf8ffd3b92436a09b0f2726277
commit 37b4043b8e4f08bf8ffd3b92436a09b0f2726277
Merge: 1bfc0e3 67a4b1d
Author: abat <abat@bigswitch.com>
Date:   Thu Nov 13 17:08:43 2014 -0800

    Merge into master from pull request #352:
    Java bundle improvements (https://github.com/floodlight/loxigen/pull/352)

commit 67a4b1dd4b0bee2a7b632a1f0ffdcc6c8783e4fb
Merge: 3846e55 1bfc0e3
Author: Andreas Wundsam <andreas.wundsam@bigswitch.com>
Date:   Wed Nov 12 18:04:01 2014 -0800

    Merge remote-tracking branch 'upstream/master' into java-bundle-improvements

commit 3846e55d676352214b16449662bb10a4516290d4
Author: Andreas Wundsam <andreas.wundsam@bigswitch.com>
Date:   Wed Nov 12 17:10:33 2014 -0800

    java: check whether required fields have been set in messages

    This helps by raising an NPE early if an incomplete messages is
    to be constructed that is missing required members.

    Previously, the message construction would succeed, but the
    message serialization could fail with an NPE.

commit b3ecc22752cf59aac7aaeba186840c419cf22a4e
Author: Andreas Wundsam <andreas.wundsam@bigswitch.com>
Date:   Wed Nov 12 17:10:01 2014 -0800

    ClassId: output as unsigned int

commit 73d7d6723da11674591a634400d2fc769b037fe0
Author: Andreas Wundsam <andreas.wundsam@bigswitch.com>
Date:   Wed Nov 12 17:07:33 2014 -0800

    java_gen: API improvements for BundleMessages.

    This commit introducesa BundleId class that models the bundle id,
    and enables us to use OFBundleCtrlMsg in our usual writeRequest()
    framework (in detail, we make the OFBundleCtrlMessage an OFRequest,
    its response type is also OFBundleCtrlMsg).

    It would be somewhat cleaner from Java's perspective to Factor
    out the individual OFBundleCtrlMessage subtypes into their
    own request/responses (like we do with flod_mods).

commit 4138571b4bae587506bc40d71c294e99874eb241
Author: Andreas Wundsam <andreas.wundsam@bigswitch.com>
Date:   Wed Nov 12 17:01:53 2014 -0800

    java_gen/GenericReader: BUGFIX version dispatch for hybrid

    This commit fixes a bug in OpenFlowJ's GenericReader. GenericReader
    previously dispatched to the version specific readers based on
    bb.getByte(0). This turns out to be the first *absolute* byte in the
    ChannelBuffer, not the first readable byte at the current readerIndex.

    I.e., if several messages were queued in the ChannelBuffer, the Generic
    Reader would always dispatch according to the version of the first
    message.

    In standard use, we pin the OF version after we receive the HELLO
    from the switch. Hence, this was not a problem observed in practice.

    It could cause problems for hybrid mode connections.