On Tue, Apr 15, 2014 at 10:04:05AM -0700, Josh Nichols wrote:
> > +        if msg.match[2] == undefined
> 
> Coffeescript has an existential operator `?` which reads a little
> bit better

Thanks for the hint.  Fixed in a rebase and force-pushed.

> It might also read nicer to assign this to a variable, ie `repo`
> since the hear regex is pretty hard to grok.

I split it up into a block regexp with comments, so it should be
easier now.

Tue, Apr 15, 2014 at 10:05:16AM -0700, Josh Nichols:
> > -  robot.hear /.*(\b[0-9a-f]{7}\b|\b[0-9a-f]{40}\b).*/i, (msg) ->
> > +  robot.hear /.*?\b(([^\s@]+)@)?([0-9a-f]{7,40})\b.*/i, (msg) ->
> 
> If I'm reading this right, I don't think you're actually using
> `msg.match[1]`, so you might make it non-capturing.

Fixed in a rebase and force-pushed.

Tue, Apr 15, 2014 at 10:07:08AM -0700, Josh Nichols:
> sorry for the delay.

No problem.  It's easy to deploy my tweaked version until this lands,
so there's no rush.

> That's part of the reason for
> https://github.com/github/hubot-scripts/issues/1113

Having well defined maintainers for each script makes sense to me.

> I left some feedback, and I think it should be good after making
> those few changes.

I think I've fixed the stuff you pointed out.  I'll report back after
testing the rebased version locally.