Small cleanup of Bosh::Dev::GemComponents

- Privatize a method which should be private
- Only add pg/mysql gems once for a component that requires them
- Use build_dir instead of specifying "/tmp/all_the_gems/<pid>" again

Signed-off-by: John Foley <jfoley@pivotallabs.com>
Use Bundler for bosh-director and bosh-monitor deps

RubyGems doesn't resolve prerelease dependencies when installing gems; Bundler
does. The dependency on nats-0.5.0.beta.12 triggered this.

Signed-off-by: John Foley <jfoley@pivotallabs.com>
Add space to warning message

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
bump gems for ruby 2.1.2

Signed-off-by: Phan Le <ple@pivotallabs.com>
Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
declaring rubocop bankruptcy

Signed-off-by: Phan Le <ple@pivotallabs.com>
Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Update eventmachine and nats

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Convert specs to RSpec 3.0.0 syntax with Transpec

This conversion is done by Transpec 2.2.1 with the following command:
    transpec spec/unit/validation_helper_spec.rb

* 6 conversions
    from: obj.should
      to: expect(obj).to

* 5 conversions
    from: expect { }.should
      to: expect { }.to

For more details: https://github.com/yujinakayama/transpec#supported-conversions
switch from pending to skip

Signed-off-by: Phan Le <ple@pivotallabs.com>
switch from should_receive in favor of allow/expect.to receive

Signed-off-by: Phan Le <ple@pivotallabs.com>
remove and_return with blocks

Signed-off-by: Phan Le <ple@pivotallabs.com>
described_class was not working with rspec 3.0, so switch to being explicit

Signed-off-by: Phan Le <ple@pivotallabs.com>
remove unneeded test

Signed-off-by: Phan Le <ple@pivotallabs.com>
fix random rspec API changes

Signed-off-by: Phan Le <ple@pivotallabs.com>
switch style of skipping os_image tests

Signed-off-by: Phan Le <ple@pivotallabs.com>
switch style of skipping stemcell_image tests

Signed-off-by: Phan Le <ple@pivotallabs.com>
update rspec, serverspec, specinfra (and related monkeypatches)

Signed-off-by: Phan Le <ple@pivotallabs.com>
remove instafail from gemfile.lock

Signed-off-by: Phan Le <ple@pivotallabs.com>
Bump rubocop

Signed-off-by: Phan Le <ple@pivotallabs.com>
Add description to stemcell:build task

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Change pending to skip in BATs tests

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>