1. add getall combination code