GR-43, expand filter options

Work in progress, to be tested in staging
I'd rather keep 'tbl_alias' than disable the cop

On Tue, Dec 16, 2014 at 3:02 PM, Mark Knutsen <notifications@github.com>
wrote:
>
> In app/models/entity/filter.rb
> <https://github.com/CruGlobal/global_registry/pull/42#discussion-diff-21927273>
> :
>
> >        field_name_entity_type = relationship_type.relationship_entity_type.children.find_by(name: field_name)
> >        raise Error unless field_name_entity_type
> >
> >        value.each do |k1, v1|
> > -        table_alias = quote(k1.to_s + '_r')
> > +        tbl_alias = quote(k1.to_s + '_r')
>
> This routine, already factored once, is up against the rubocop
> MethodLength limit, and with the longer variable would exceed the rubocop
> LineLength limit by (annoyingly) one character on line 263. May I be
> granted a rubocop:disable?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CruGlobal/global_registry/pull/42/files#r21927273>.
>