Respect SVG fragment identifiers in <img> src attribute
https://bugs.webkit.org/show_bug.cgi?id=129387

Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/css/svg-resource-fragment-identifier-img-src.html

When providing an SVG image for a given renderer, check that the URL used to load
that image is taken into account in case it featured a fragment identifier, ensuring
that the CSS :target pseudo-class is correctly handled for SVG resources. This patch
is specific to <img> elements, specific support will also need to be added for various
CSS properties that support SVG images.

* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageForRenderer):
Check if the provided renderer is attached to an <img> element and, if so, pass the
resolved <img> source URL, taking into account srcset, to the SVGImageForContainer.

* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::setURL):
Trigger the FrameView machinery to ensure that the :target pseudo-class is respected
should the provided URL feature a fragment identifier.

* svg/graphics/SVGImageForContainer.h:
Declare the new setURL() method.

LayoutTests:

Test that we correctly handle the fragment identifier used in SVG URLs in <img> elements,
checking for correct srcset handling as well.

* svg/css/resources/fragment-identifiers.svg: Added.
* svg/css/svg-resource-fragment-identifier-img-src-expected.html: Added.
* svg/css/svg-resource-fragment-identifier-img-src.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r164783.
http://trac.webkit.org/changeset/164783
https://bugs.webkit.org/show_bug.cgi?id=129425

Broke number of multicol tests (Requested by anttik on
#webkit).

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

* fast/css/crash-on-column-splitting-expected.txt: Removed.
* fast/css/crash-on-column-splitting.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
https://bugs.webkit.org/show_bug.cgi?id=127076

Reviewed by Anders Carlsson.

Avoid match for :: as start of a member initialization list. Modify expression to match
after a colon either non-colon character or end of line.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_member_initialization_list):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_member_initialization_list):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
speechSynthesis.speak of a zero length utterance kills future speech
https://bugs.webkit.org/show_bug.cgi?id=129403

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Empty length strings may choke a synthesizer and result in didFinishSpeaking not being called.
The WebKit code should be proactive about screening out empty length strings.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-speak-empty-string.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::startSpeakingImmediately):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-speak-empty-string-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-speak-empty-string.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@164807 268f45cc-cd09-0410-ab3c-d52691b4dbfc