First PR for Npgsql technical debt cleanup

I've started with the codebase cleanup. As a lot of the code is a bit chaotic due to all the changes done over the past years by various authors, it's best to clean the stuff up a bit, weed out dead code and the like, restructure files, make everything look the same and professional and more predictable, so it's easier to understand when reading the code. 

I've started with the connectionstring builder. I had cleaned up the connection class as well, but that was in v2.2, and as it changed a lot in v3 branch, I'll re-do that one later. 

(all tests pass)
I'll add an entry in our code style to reflect that space in the foreach.


On Fri, Nov 7, 2014 at 2:47 PM, Shay Rojansky <notifications@github.com>
wrote:

> In Npgsql/NpgsqlConnectionStringBuilder.cs:
>
> > @@ -253,1070 +325,1016 @@ public NpgsqlConnectionStringBuilder Clone()
> >          {
> >              NpgsqlConnectionStringBuilder builder = new NpgsqlConnectionStringBuilder();
> >
> > -            foreach (string key in this.Keys)
> > +            foreach(string key in this.Keys)
>
> We don't have any formal style for this kind of thing, but I put a space
> after for, foreach etc. (and a lot of code is currently written this way)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/npgsql/npgsql/pull/414/files#r20021340>.
>



-- 
Regards,

Francisco Figueiredo Jr.
Npgsql Lead Developer
http://www.npgsql.org
http://gplus.to/franciscojunior
http://fxjr.blogspot.com
http://twitter.com/franciscojunior