Refactor SmellWarning.

The title says it all. I:

- removed constants i felt were overengineering.
- removed dead code
- restructured everything else a bit