fragtree: remove dead code

Signed-off-by: John Spray <john.spray@inktank.com>
fragtree: remove unused and broken verify()

This fn had a while(1) with no break: if anyone
had called it it would block forever.

Caught by clang's "function 'verify' could be declared
with attribute 'noreturn'" warning.

Signed-off-by: John Spray <john.spray@inktank.com>
encoding: make .size() to __u32 cast explicit

Caught by clang warning that this is a conversion
from "unsigned long" to "unsigned int" which can
lose precision.  However, this is the conversion
we want because our serialization format defines
sizes as 4 bytes.

Signed-off-by: John Spray <john.spray@inktank.com>
mds: Remove redundant 'using namespace std'

This simply was not being used, and triggered
a clang warning.

Signed-off-by: John Spray <john.spray@inktank.com>
mon: Fix % escaping (\% should be %%)

Clang's -Wpedantic points this out.

Signed-off-by: John Spray <john.spray@inktank.com>
os/FileJournal: remove unused attribute

Clang:
os/FileJournal.h:224:8: warning: private field 'is_bdev' is not used
[-Wunused-private-field]

Signed-off-by: John Spray <john.spray@inktank.com>
rgw: Remove trailing ; from fn definitions

Clang:
warning: extra ';' after member function
definition [-Wextra-semi]

Signed-off-by: John Spray <john.spray@inktank.com>
Merge pull request #1789 from ceph/wip-jcsp-clang

misc. cleanups from clang warnings

Reviewed-by: Sage Weil <sage@inktank.com>