update:add good check and add attr check