2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * Source/WebKit.pro:
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * QtWebKit.pro:
        * symbian/platformplugin/WebPlugin.cpp: Removed.
        * symbian/platformplugin/WebPlugin.h: Removed.
        * symbian/platformplugin/platformplugin.pro: Removed.
        * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unskip a bunch of passing tests and update their expected files.
This patch based on work of Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

* platform/qt/Skipped:
* platform/qt/fast/[...]: Added, updated.
* platform/qt/scrollbars/[...]: Added, updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-22  Geoffrey Garen  <ggaren@apple.com>
        
        Rolled back in r84725 and r84728 with appcache crash fixed.

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: DOMWindow
        https://bugs.webkit.org/show_bug.cgi?id=59260

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
        we use the opaque roots system now.

        * bindings/js/JSNavigatorCustom.cpp: Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
        whose opaque roots are frames.

        * css/StyleMedia.h:
        (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.

        * css/StyleMedia.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * page/BarInfo.idl:
        * page/Console.idl:
        * page/DOMSelection.idl:
        * page/Geolocation.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.idl:
        * page/Screen.idl:
        * storage/Storage.idl: Updated to use the opaque roots system.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixed an upside-down conditional in my last check-in.

* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::isObservable):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect bug.

* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-22  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Upgrade CSS loads from mixed content warning (displayed) to mixed
        content error (ran)
        https://bugs.webkit.org/show_bug.cgi?id=59056

        * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-iframe.html: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-main-frame.html: Update expectation.
        * http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Fix typo.
2011-04-22  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Upgrade CSS loads from mixed content warning (displayed) to mixed
        content error (ran)
        https://bugs.webkit.org/show_bug.cgi?id=59056

        Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
        Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebCore.exp.in: adding method to allow changing style
        * page/FrameView.cpp:
        (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
        * page/FrameView.h:
        * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
        * platform/ScrollableArea.h:
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-19  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        [V8] Use implicit references for V8 listeners on DOM nodes.
        https://bugs.webkit.org/show_bug.cgi?id=58953

        Instead of allocating an auxiliary V8 array referencing V8
        listener objects associated with a DOM node and using an extra
        pointer in every DOM node wrapper, we can register implicit
        references between nodes and their listeners during GC. This also
        makes V8 bindings more aligned with JSC bindings.

        No new tests because this is a refactoring.

        * bindings/scripts/CodeGeneratorV8.pm: Stopped generating the
        listener cache internal field for DOM nodes.
        * bindings/v8/V8AbstractEventListener.h: Exposed the lister handle
        to the GC.
        (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
        * bindings/v8/V8GCController.cpp: Started using implicit references.
        (WebCore::GrouperVisitor::visitDOMWrapper):
        * dom/EventTarget.h: Implemented an iterator over all listeners.
        (WebCore::EventListenerIterator):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  Alexey Proskuryakov  <ap@apple.com>

        Unreviewed.

        REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59241
        <rdar://problem/9150861>

        * http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
        Resource load delegates for cancelled loads are now correctly sent before frame load
        delegate's didFinishLoading, so cancellation errors get logged by DumpRenderTree.
2011-04-23  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59241
        <rdar://problem/9150861>

        Covered by manual-tests/print-after-window-close.html.

        Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
        regression.

        * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be
        doing complicated work while the loader is half-canceled.

        * manual-tests/print-after-window-close.html: Extended to actually print a non-empty page,
        thus being more practical.

        * page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer.
        It's too scary for me to try now.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::finishedLoading):
        * page/DOMWindow.h:
        Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[wx] Unreviewed build fixes for recent trunk changes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Bug 59266 - DFG JIT - Add SSA style DCE

Reviewed by Sam Weinig & Geoff Garen.

This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
* dfg/DFGNode.h:
(JSC::DFG::Node::ref):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
        https://bugs.webkit.org/show_bug.cgi?id=59281

        * fast/dom/HTMLMeterElement/meter-writing-mode.html: Added.
        * fast/dom/HTMLProgressElement/progress-writing-mode.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
2011-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
        https://bugs.webkit.org/show_bug.cgi?id=59281

        Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
        for vertical writing modes. This fix added a width property for each of them.

        Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
               fast/dom/HTMLProgressElement/progress-writing-mode.html

        * css/html.css:
        (meter::-webkit-meter-bar):
        (progress::-webkit-progress-bar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  MORITA Hajime <morrita@google.com>

        Unreviewed test_expectations.txt update.
        r84745 didn't fix meter-element.html break on chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  MORITA Hajime <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
        https://bugs.webkit.org/show_bug.cgi?id=59280

        - Rename NodeRenderParentDetector to NodeRendererFactory
        - move createRendererAndStyle() and createRendererIfNeeded to
          NodeRendererFactory

        No new test, no behavioral change.

        * dom/Node.cpp:
        (WebCore::NodeRendererFactory::NodeRendererFactory):
        (WebCore::NodeRendererFactory::document):
        (WebCore::NodeRendererFactory::nextRenderer):
        (WebCore::NodeRendererFactory::findVisualParent):
        (WebCore::NodeRendererFactory::shouldCreateRenderer):
        (WebCore::NodeRendererFactory::createRendererAndStyle):
        (WebCore::NodeRendererFactory::createRendererIfNeeded):
        (WebCore::Node::parentNodeForRenderingAndStyle):
        (WebCore::Node::createRendererIfNeeded):
        * dom/Node.h:
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:

Reviewed by Oliver Hunt.

SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        * fast/dom/shadow/gc-shadow-expected.txt: Added.
        * fast/dom/shadow/gc-shadow.html: Added.
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        Test: fast/dom/shadow/gc-shadow.html

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId): group shadow nodes with their hosts
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        Chromium DRT over-refcounted the NPObject wrappers it used to
        marshal shadowRoot nodes back to tests (WebBindings::makeNode
        births NPObjects with referenceCount == 1). This masked the GC bug
        59284 in tests by making shadowRoot nodes live forever.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::shadowRoot):
        (LayoutTestController::ensureShadowRoot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
https://bugs.webkit.org/show_bug.cgi?id=59288

Reviewed by Simon Fraser.

Source/WebCore: 

* platform/text/mac/TextBoundaries.mm:
(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.

LayoutTests: 

* editing/text-iterator/findString-expected.txt:
* editing/text-iterator/findString.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebCore.exp.in:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/ScrollTypes.h:
        * platform/ScrollableArea.h:
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Area under composited scrollbars not repainted in WebKit2 on scrolling
        https://bugs.webkit.org/show_bug.cgi?id=59294
        <rdar://problem/9299062>

        When computing the rect that can be copied on scrolling, we normally
        exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
        the assumption is that other code will repaint these areas. However, when
        scrollbars are in their own compositing layers, we can, and should
        copy the entire area.

        Not testable in DRT because it does not allow tests to use overlay scrollbars.

        * platform/ScrollView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::rectToCopyOnScroll):
        New method, with code moved from scrollContents and fixed to look
        for scrollbars in layers.
        (WebCore::ScrollView::scrollContents):
        Call rectToCopyOnScroll().

        * platform/ScrollableArea.h:
        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
        (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
        (WebCore::ScrollableArea::hasLayerForScrollCorner):
        Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-23  Simon Fraser  <simon.fraser@apple.com>

        Fix Windows build, which complains about unreachable code.

        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
        (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
        (WebCore::ScrollableArea::hasLayerForScrollCorner):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84753 268f45cc-cd09-0410-ab3c-d52691b4dbfc