Fix SchemaPath.legacyPath visibility

Thread safety is not assured without legacyPath being volatile.

Change-Id: I7e69777cb4af6b3bc359a0a2b218ecdba433f369
Signed-off-by: Robert Varga <rovarga@cisco.com>
Simplify YangInstanceIndentifier references

Change-Id: I272b332b87f05ef03c27f0e38256c64a70dd92f4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Uint16 shared instance should be final

Reported by sonar.

Change-Id: I3b33c1d65db865c3bfebf4e455044b3d5a941397
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix ObjectCacheFactory thread safety

The global factory instance needs to be volatile to guarantee proper
visibility. Also fix a sonar warning about field naming.

Change-Id: Ia0fd50d7a2a6210dbda1c1e2f0615ac05512eb64
Signed-off-by: Robert Varga <rovarga@cisco.com>
Make sure to use exception chaining

Preserving the original exception is critical for finding the root
cause, so let's keep it available via getCause(). Fixes a sonar warning.

Change-Id: I1315d228df13460a76be3e3dd6a97d03ed1723a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Improve UnionType.toString()

Do not create itermediate string just to pass it into a StringBuilder.
Fixes a sonar warning.

Change-Id: I424c1686bd919255d306c1934cb67779b7a07f52
Signed-off-by: Robert Varga <rovarga@cisco.com>
Do not use String.toString()

It is obviously not needed. Fixes a sonar warning.

Change-Id: I944acc591793520c62907f90924fc0d730646d49
Signed-off-by: Robert Varga <rovarga@cisco.com>
IdentifiableItemCodec should be a static inner class

Headline really says it all. There is no reason for
IdentifiableItemCodec to be non-static.

Change-Id: I713625dbea7201a9f11d5431d81584528ddb74aa
Signed-off-by: Robert Varga <rovarga@cisco.com>
Compare booleans via equals()

Fixes a sonar warning.

Change-Id: Ifd39bfb8318b406365901117647be581d18ef9e7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Remove explicit final keywords

These context use the filan modifier needlessly, so remove them to get
rid of sonar warnings.

Change-Id: I1ec3133c3978b0cfaa31c74ba57393ff9973ddc6
Signed-off-by: Robert Varga <rovarga@cisco.com>