kafka: compression codec is unsigned

Change-Id: I238e93dd035caa359fed768aa2aac4df5a0ef47e
Reviewed-on: https://code.wireshark.org/review/4875
Reviewed-by: Evan Huus <eapache@gmail.com>
OS X: Add retina / hidpi support to Info.plist.

This should partially fix the problem described at
https://ask.wireshark.org/questions/37177/pixelated-ui-on-mac-os-x-with-development-1990

Change-Id: I436aae0d5b681e9ff549d257c2244ee67448ab07
Reviewed-on: https://code.wireshark.org/review/4876
Reviewed-by: Gerald Combs <gerald@wireshark.org>
tn5250: fix an endless loop, exit when offset is not incremented

Bug: 10596
Change-Id: I64509aa49fce4893dee4e7a74a560e09a98830f6
Reviewed-on: https://code.wireshark.org/review/4878
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Proto: Fixed proto_unregister_field()

This function did not work after svn revision 51396.
This fix affects http, imf and ldap preferences.

Change-Id: I6fcb24c968d03c7d1fdc018cfa907f9cfd8809bb
Reviewed-on: https://code.wireshark.org/review/4881
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Fix support for writing out edited records.

Add a cf_set_frame_edited() routine to set the record header and data
for a record; have it do all the non-GUI work, and have it set the
file's "unsaved changes" flag.

Have the GUI code just call that routine and then update the title bar
to reflect the unsaved changes.

While we're at it, unmark a no-longer-unused argument to save_record().

Change-Id: Ieb513fdf423b388519527621ecec4cf634b98caf
Reviewed-on: https://code.wireshark.org/review/4885
Reviewed-by: Guy Harris <guy@alum.mit.edu>
kafka: summarize number of messages in a set

Change-Id: I62873a147426079aa4890289320c43ef7f1b26dc
Reviewed-on: https://code.wireshark.org/review/4877
Reviewed-by: Evan Huus <eapache@gmail.com>
Export cf_set_frame_edited().

Change-Id: I6569b020ff00d6748840a00ca418653d9e3fdb9b
Reviewed-on: https://code.wireshark.org/review/4886
Reviewed-by: Guy Harris <guy@alum.mit.edu>
CMake: Use WIRESHARK_LIB_DIR. Fix GThread check on Windows.

Have FindWSWinLibs check for WIRESHARK_LIB_DIR before WIRESHARK_BASE_DIR
to match the behavior of config.nmake and the Windows buildbots, which
set the former but not the latter.

It looks like the latest GLib DLL contains GThread. Adjust
FindGTHREAD2.cmake accordingly.

Change-Id: I0232b1819eca9ba2c39ae6834daddf65af979d7d
Reviewed-on: https://code.wireshark.org/review/4887
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Fix a number of what appear to be errors.

Add checks for too-short length fields.

Increment the offset after some proto_tree_add_item() calls to skip past
the item.

Make some other length calculations use the start of the item to which
the length applies, not the start of the *list* of items.

Fix a double-digit field to be 2 bytes long (as the documentation says
it is).

Add a comment about a field that isn't always present but that's
specified in a tn5250_add_hf_items() list.

Fix DEFINE PITCH TABLE to match what the documentation appears to say it
is.

Change-Id: Ibcdc580045c68e8d0d8f35011dfe72b9c245e157
Reviewed-on: https://code.wireshark.org/review/4888
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Fix the earlier checkin.

Remove some trailing white space while we're at it.

Change-Id: If399077a799e24302640776760b4388687ecad4f
Reviewed-on: https://code.wireshark.org/review/4889
Reviewed-by: Guy Harris <guy@alum.mit.edu>
file.c isn't in a DLL, so what it exports shouldn't be WS_DLL_PUBLIC.

Change-Id: I1fcd0422703d21ce3d0764a23bd491708ffc6785
Reviewed-on: https://code.wireshark.org/review/4890
Reviewed-by: Guy Harris <guy@alum.mit.edu>
With CMake, define WANT_PACKET_EDITOR in config.h.

Just as we do with autotools and nmake, define it in config.h, so it's
defined the same for every single file, rather than defining it in one
particular directory's Makefiles, so that it's defined for some code but
not all.

Change-Id: Ic41cd10f2b502e0be76c134cbeaad94dff7623f8
Reviewed-on: https://code.wireshark.org/review/4891
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Handle an hfindex of -1.

Code generated by the current version of Pidl dissects bitset fields
twice - once with proto_tree_add_item(), which puts the actual item into
the tree, so that we can create a subtree under it, and once with a
dissect_dcerpc_{type}() routine, to fetch the value and step past the
field.  The second call passes an hf_ index value of -1; interpret that
as meaning "don't put this into the protocol tree", rather than just
blindly calling proto_tree_add_XXX with -1 and getting a dissector
assertion.

Change-Id: I42fc023e77514a8a8a25d5c9db11fa3ef053babf
Reviewed-on: https://code.wireshark.org/review/4892
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add OID dissector table for PER based dissection.

Change-Id: Iaf789017e997eddf7d6dc596eb40fdef413bfd68
Reviewed-on: https://code.wireshark.org/review/4778
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add OID callback for private IEs making it possible to call a dissector
for the private OID.

Change-Id: Ibb86d8523f1aee14ba1a843ec3ad4becc7729013
Reviewed-on: https://code.wireshark.org/review/4893
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Make the "-qt" option the default in the OS X packaging scripts.

Change-Id: I1e404c342d06381be71735ff6fbc47e9b2b13899
Reviewed-on: https://code.wireshark.org/review/4895
Reviewed-by: Gerald Combs <gerald@wireshark.org>
no need for continue at the end of a while loop, we loop anyway

Change-Id: I96ff9ee0967fcdb2c8122649a2363a36ea2a2882
Reviewed-on: https://code.wireshark.org/review/4884
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
no need for if(tree)

Change-Id: I529a601ce83c446247cee1e87386622462f24f56
Reviewed-on: https://code.wireshark.org/review/4896
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
tn5220: prevent another potential endless loop
exit the loop if dissect_unknown_data() returns 0

Change-Id: I681d170d4daf8efb06231790652ff7c941b46d89
Reviewed-on: https://code.wireshark.org/review/4882
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
fix wrong offset for ID Capability Flags 1
reported by Jean-Marc Lamond

Bug: 10597
Change-Id: I481fad9cd0b8d55e3dd3af00cde2897105547f13
Reviewed-on: https://code.wireshark.org/review/4898
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>