The fixed height is a punishment for using an iframe ;-) As discussed, we
much prefer fragments. It turns out that the interactive designers prefer
knowing exactly what the height will be anyway. 200 is a conservative
measure of the height of the smallest item we load snaps into.


On 7 May 2014 08:31, James Gorrie <notifications@github.com> wrote:

> In facia/app/assets/javascripts/modules/ui/snaps.js:
>
> > +
> > +            breakpoint.action = isAdd ? 'addClass' : isResize ? 'removeClass' : false;
> > +            return breakpoint;
> > +        })
> > +        .filter(function(breakpoint) { return breakpoint.action; })
> > +        .forEach(function(breakpoint) {
> > +            $el[breakpoint.action](prefix + breakpoint.name);
> > +        });
> > +    }
> > +
> > +    function injectIframe(el) {
> > +        var iframe = document.createElement('iframe');
> > +
> > +        iframe.style.width = '100%';
> > +        iframe.style.border = 'none';
> > +        iframe.height = '200';
>
> Any particular reason 200?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/guardian/frontend/pull/4088/files#r12364068>
> .
>

-- 

------------------------------
Visit theguardian.com.  On your mobile, download the Guardian iPhone app 
theguardian.com/iphone and our iPad edition theguardian.com/ipad<http://theguardian.com/iPad>. 
 Save up to 57% by subscribing to the Guardian and Observer - choose the 
papers you want and get full digital access.  Visit 
subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be 
privileged. If you are not the named recipient, please notify the sender 
and delete the e-mail and all attachments immediately. Do not disclose the 
contents to another person. You may not use the information for any 
purpose, or store, or copy, it in any way.  Guardian News & Media Limited 
is not liable for any computer viruses or other material transmitted with 
or as part of this e-mail. You should employ virus checking software.
 
Guardian News & Media Limited is a member of Guardian Media Group plc. Registered 
Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP.  Registered 
in England Number 908396