I wrote it and I agree.

On Thursday, May 1, 2014, Alex Stapleton <notifications@github.com> wrote:

> In cryptography/hazmat/backends/openssl/backend.py:
>
> > +                                       algorithm)
> > +
> > +    def _dsa_cdata_from_public_key(self, public_key):
> > +        # Does not GC the DSA cdata. You *must* make sure it's freed
> > +        # correctly yourself!
> > +        ctx = self._lib.DSA_new()
> > +        assert ctx != self._ffi.NULL
> > +        parameters = public_key.parameters()
> > +        ctx.p = self._int_to_bn(parameters.p)
> > +        ctx.q = self._int_to_bn(parameters.q)
> > +        ctx.g = self._int_to_bn(parameters.g)
> > +        ctx.pub_key = self._int_to_bn(public_key.y)
> > +        return ctx
> > +
> > +    def dsa_hash_supported(self, algorithm):
> > +        if (
>
> This is some horrible formatting.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/982/files#r12183877>
> .
>