WPrefs: fix segfault when image not found

Previously, when an image could not be loaded by WPrefs when rendering textures
for the Appearances panel, a segfault would occur.  This could happen, e.g., if
a user moved or deleted an image file without editing their ~/GNUstep/Defaults/
WindowMaker file.

This patch first checks if a texture contains an image, and if it does, it
checks to see if that image can be loaded.  If it can't, a solid black texture
is loaded instead.

The patch also has the added benefit of combining some of the code used for
rendering both pixmap and textured gradient textures.
add util/wmiv to .gitignore
WPrefs: Value stored to 'timage' is never read

three times in a row

Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
WPrefs: remove unfinished background tab from appearances panel code

WPrefs.app/Appearances.c contained code for an unfinished feature
in the appearances panel of WPrefs, a tab for setting the background.

Since this feature has now been implemented as part of the texture
tab (see commit c2aca1a ("WPrefs: Set workspace background")), there
is no reason to keep this code.
WPrefs: new enum in Appearances.c for tab identifiers to increase readability
doc: Update getstyle and setstyle manpages.

The manpages for getstyle and setstyle have not been updated and were missing
some options.  This patch brings them up to date.

In addition, the *TitleExtendSpace options were appearing twice in getstyle.c.
One of the unnecessary sets was removed.
WPrefs: Add ability to edit FrameBorderColor/FrameSelectedBorderColor.

As part of the process, some #defines were turned into enums.  Also, the *_COL
when needed.

This brings the code for colors in line with the code for textures, and
allows us to use them as array indices to improve readability, e.g.,
colorOptions[MTITLE_COL] instead of colorOptions[3].
WINGs: changed use of 'if' on panel->rgbState into a switch

This allow compiler to raise a warning in case a new value would be added
to the enum; it also change order in the check so that WMGetButtonSelected
will be called only once, only for the case of interest.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
WMaker: moved XGrab/XUngrabPointer into the conditional code

It is not necessary to call them when the command is not executable.
Took opportunity to change parameter to XSync which is supposed to be a
'Bool' type from Xlib, which means either True or False.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
News: created section dedicated to the changes related to 0.95.3
News: added description of a change that may be interesting to users
News: added section to describe the changes that have occured in 0.95.4
News: marked the current changes as part of 0.95.5 and describe the drawers feature
News: described the new features for future 0.95.6 release
News: ran spell-checker on the file

Lang was set to en_US to have consistency in the file.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
src/appicon.c: updated paint_app_icon

moving scr initialization after WApplication existing test
to prevent crashing in case wapp is null

Acked-by: Christophe CURIS <christophe.curis@free.fr>
WMaker: rewrote generation of title for the Icon Chooser to avoid problems

The original code did have a few weaknesses, including:
 - possible buffer overflow, if the translation was too long;
 - possible crash, if either instance or class is NULL but not both

Now the appropriate length is calculated (not counting on a margin) and the
string is generated with the available elements.

As a side note, the variable was renamed from 'tmp' to 'title' for clarity.

This was highlighted by cppcheck (thanks to David Maciejak) and by
Coverity (bug #50078).

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
src/misc.c: updated GetShortcutString

remove unused var and remove some commented code too

Acked-by: Christophe CURIS <christophe.curis@free.fr>
src/usermenu.c: updated wUserMenuRefreshInstances

remove unused var and move wwin check

Acked-by: Christophe CURIS <christophe.curis@free.fr>
src/winmenu.c: updated prepare_menu_position

did some change as prepare_menu_position never updated x and y values

Acked-by: Christophe CURIS <christophe.curis@free.fr>