missing check for empty string