Fix config option names in ml2_conf_sriov.ini

Config option names in ml2_conf_sriov.ini file are
not in sync with definitions in source code.

Change-Id: Ic8f7b6b8e9acd022623daabd2b209b864caa0b06
Closes-Bug: #1357339
Set firewall state to CREATED when dealing with DVR

When DVR is enabled as a default option for creating routers, firewall
resources will need to have a new initial state, so that reconciliation
can be done once all L3 agents have processed the firewall rules.

The new state has been introduced to preserve API bw compatibility
with centralized routers.

Partial-bug: #1360351
Supports-blueprint: neutron-dvr-fwaas

Change-Id: I53122570dd3a2311eedb24ccd925bcdc9ad4f70c
Fix l3 agent scheduling logic to avoid unwanted failures

In case router is being added to l3 agent which is already hosting
the router it is fine to let such a request to succeed.
This patch also adds a check for unnecessary scheduling that might happen
twice in described case and lead to unwanted messages in the logs.

Change-Id: Id104b36ba7e1e6f6a9378ee600c33e9962230521
Closes-Bug: #1358636
Fix func job hook script permission problems

- The hook script is the wrong place to unstack since
  it needs to run as the stack user with sudo privileges and those
  permissions are removed as part of the devstack-vm-gate.sh script.

- The functional job gate hook script needs to use sudo to
  install the test-only rootwrap filter.

Change-Id: Ib2e5ec016a5a414dd9675328650efb2b39b0e3fe
Related-Bug: #1360658
Do not use auto_schedule_routers to add router to agent

auto_schedule_routers makes a number of DB calls that are
unnecessary as they are already made during the validation
phase of add_router_to_l3_agent. Once the validation is
done, the only business left is to create the binding: this
is what this patch does.

Partial-bug: #1356121

Change-Id: Ia9be998c2b94416bc46ef78415099f0099b08c2a
Use lockutils module for tox functional env

A previous change (I4d6076e5f7586a11ea5381f18774d4bab57b0081) added
lockutils to only the dsvm-functional tox env.  It also needs to be
added to the functional tox env.

Change-Id: I3a799692b2162b738a2b080e08602b403c171e4f
Closes-Bug: 1332380
Merge "Fix l3 agent scheduling logic to avoid unwanted failures"
Merge "Fix config option names in ml2_conf_sriov.ini"
Merge "Do not use auto_schedule_routers to add router to agent"
Merge "Fix func job hook script permission problems"
Merge "Set firewall state to CREATED when dealing with DVR"
Merge "Use lockutils module for tox functional env"