Remove unused nova.crypto.compute_md5()

Remove nova.crypto.compute_md5() as it is:
 * unused
  * last user removed 3 years ago with commit bab3060
 * untested
 * incorrectly documented
  * return type is not a tuple, but a string
 * redundant
  * copied from boto which is a nova requirement
 * burdened with license text more verbose than associated code

Change-Id: Ia033d3359098fc0af8de00248dc14b4fe280e844
Fix wrong used ProcessExecutionError exception

This class has been moved to nova.openstack.common.processutils,
but a wrong usage is exists in nova.virt.libvirt.volume,
correct here.

Closes-bug: #1308839
Change-Id: I76f99b63dc5097b462dcff6ff63cbbb13d7580fb
Fix v3 API extension names for camelcase

Most v3 API names are camelcase, but few APIs are not.
This patch changes them to camelcase for the consistency.

Change-Id: I0dc6c23ffcdcf97fc52d3575d521692805ffd9e3
Closes-Bug: #1315597
Remove logging in libvirt _connect_auth_cb to avoid eventlet locking

The _connect_auth_cb callback is logging a warning if credentials are
passed to the method from libvirt when connecting, but the comment right
above where the connection method is called on libvirt, it says don't do
any logging in that function because it can cause issues with how
eventlet does logging.

This has probably never been an issue because libvirt hasn't passed
credentials back to the callback, but if it did at some point we could
have a nasty locking problem so let's clean it up now.

See commit e4b0d8e9 for some related history.

The nested method is moved up a level so it can be tested directly.

Change-Id: Ie47aabbf81c5aeda9e12e1c9acc11f6c70c4bea7
Make xenapi agent code use Instance object for updates

This makes the agent code use the Instance object that it is passed
to do the updates, instead of calling back to the old-style virtapi
instance_update() method.

Related to blueprint virt-objects-juno

Change-Id: Ied8891c974970a25f135a88303789d0c074741ee
Convert xenapi/vmops uses of instance_update to objects

This converts uses of the old instance_update() conductor method
to use the instance object in xenapi/vmops.

Related to blueprint virt-objects-juno

Change-Id: I5fab06934a7f3e7426631bb75eafe8b0d4b0806d
Make vmwareapi/vmops use Instance object for updates

This converts the one use of virtapi.instance_update() in vmops to
use the Instance object instead of the old conductor method.
Unfortunately, the affected method was apparently not tested at all,
so this adds a simple test for it.

Related to blueprint virt-objects-juno

Change-Id: I21ed4903a0c8d98c8776d358d8273077cd979fdf
Make libvirt driver use instance object for updates

This makes the libvirt driver use the Instance object for updates
instead of using the old raw conductor instance_update() method.

Related to blueprint virt-objects-juno

Change-Id: Ic25b2dc21dbc0038699f5fc33dd69334821abfc8
Add Nova API Sample file & test for get keypair

This patch adds the new API Sample file and its test for Nova V2 and V3
get keypair APIs.

This patch extend the timstamps reg exp to allow the combination
of TZ and microsecond/

Closes-Bug: 1298769
Closes-Bug: 1298818

Change-Id: If695a23cf95862b7bec6fbc5bdf7fc1733d08d4a
Unit test case for more than 1 ephemeral disks in BDM

The following patch modifies the test case for
_get_instance_block_device_info to handle more than 1 ephemeral
disks in the BDM.  This is to address one of the comments made
in https://review.openstack.org/#/c/90583/ after it was already
approved for merger.  This patch also corrects a comment in
_get_instance_block_device_info to be more accurate.

Change-Id: I11e97f2e2ef999fa08af1693483d56bf8ad0e556
Closes-Bug: #1317321
Remove conductor usage from compute.utils.EventReporter

This makes compute.utils.EventReporter use the InstanceActionEvent
object instead of making raw conductor calls. Callers are changed to
stop passing conductor API to it.

In addition, moves helper methods pack_action_event*() from
compute.utils to objects.instance_action like previously was done
with pack_action_[start|finish]().

Related to blueprint compute-manager-objects-juno

Change-Id: I308959a1b206899369a10d391991124ef014c89f
Remove explicit dependency on amqplib

kombu already depends on amqp or amqplib depending on its
version, and no explicit access to amqplib exists in nova code.

Update logging config to list both amqp and amqplib, as kombu
will setup one or the other.

Change-Id: I716050593cde15f2a614175d9849340e5858fc32
Merge "Remove explicit dependency on amqplib"
Merge "Make xenapi agent code use Instance object for updates"
Merge "Convert xenapi/vmops uses of instance_update to objects"
Merge "Make vmwareapi/vmops use Instance object for updates"
Merge "Make libvirt driver use instance object for updates"
Merge "Remove conductor usage from compute.utils.EventReporter"
Merge "Fix v3 API extension names for camelcase"
Make baremetal driver use Instance object for updates

This makes the baremetal driver use the Instance object it is passed
to do its update instead of using the old conductor raw method.

Related to blueprint virt-objects-juno

Change-Id: I4116f1645562353134534dc6b883e8052c1aa706