Easy File Management Web Server v5.3 Stack Buffer Overflow

Tested module on:
Microsoft Windows XP
Microsoft Windows 7
Microsoft Windows 8
I was going to suggest 'unless' here as well

> On Jun 9, 2014, at 4:34, OJ Reeves <notifications@github.com> wrote:
> 
> In modules/exploits/windows/http/efs_fmws_userid_bof.rb:
> 
> > +    end
> > +    if res.body =~ /What's new in Easy File Management Web Server V(\d\.\d)/
> > +      version = "#{$1}"
> > +      vprint_status "#{peer} - Found version: #{version}"
> > +      if version == "5.3"
> > +        return Exploit::CheckCode::Appears
> > +      end
> > +    end
> > +    if res.headers['server'] =~ /Easy File Management Web Server v(4\.0)/
> > +      return Exploit::CheckCode::Detected
> > +    end
> > +    Exploit::CheckCode::Safe
> > +  end
> > +
> > +  def exploit
> > +
> May I suggest we use unless for negative checks?
> 
> unless check == Exploit::CheckCode::Appears
>   fail_with(Failure::NoTarget, "#{peer} - Target does not appear to be running fmws 5.3")
> end
> Also, what do you want to do in the case of version 4.0? Do you want to go ahead and attempt the exploit anyway?
> 
> You'll need to make changes to your local branch and push the changes back up to github, the PR will automatically update.
> 
> Thanks!
> 
> —
> Reply to this email directly or view it on GitHub.