2011-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Added write barrier that was missing from put_by_id_transition
        https://bugs.webkit.org/show_bug.cgi?id=63775

        * dfg/DFGJITCodeGenerator.cpp:
        (JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a
        MacroAssembler& argument so our patching functions could use it.

        (JSC::DFG::JITCodeGenerator::cachedPutById):
        * dfg/DFGJITCodeGenerator.h:
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.

        * dfg/DFGRepatch.cpp:
        (JSC::DFG::tryCachePutByID): Missing barrier!

        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile): Updated for signature change.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        * jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier
        because its meaning isn't clear -- maybe in the future we'll have a
        clear way to pass all stores through a common function that guarantees
        a write barrier, but that's not the case right now.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Beth Dakin.

        Make GC validation clear cell structure on destruction
        https://bugs.webkit.org/show_bug.cgi?id=63778

        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::~JSCell):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebCore::defaultDetailsSummaryText()
        https://bugs.webkit.org/show_bug.cgi?id=63700

        * platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebCore::defaultDetailsSummaryText()
        https://bugs.webkit.org/show_bug.cgi?id=63700

        * public/WebLocalizedString.h: Add new key.
        * src/LocalizedStrings.cpp: Call query() with the new key.
        (WebCore::defaultDetailsSummaryText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
        https://bugs.webkit.org/show_bug.cgi?id=63704

        * http/tests/websocket/tests/bad-handshake-crash_wsh.py:
        Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
        * http/tests/websocket/tests/long-invalid-header_wsh.py:
        Content of web_socket_transfer_data() is completely bogus. It's not necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Darin Adler.

        Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
        https://bugs.webkit.org/show_bug.cgi?id=62022

        Adds XcodeProjectFileChecker to check removal of "developmentRegion".

        * Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
        * Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
        * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] Consider scale factor when allocating backing store
        https://bugs.webkit.org/show_bug.cgi?id=63766

        This is the first step in considering scale factor. It considers
        scale factor for the primary backing store, not graphics layers,
        and for CG only.

        * Platform/cg/CGUtilities.cpp:
        (WebKit::paintImage): Added a scale factor argument.
        (WebKit::paintBitmapContext): Pass 1 for scale factor.
        * Platform/cg/CGUtilities.h: Updated for above.

        * Shared/ShareableBitmap.h: Added an overload of paint that can handle
        a scale factor.

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode): Encode scale factor.
        (WebKit::UpdateInfo::decode): Decode scale factor.
        * Shared/UpdateInfo.h: Added scale factor.

        * Shared/cg/ShareableBitmapCG.cpp:
        (WebKit::ShareableBitmap::paint): Added the overload that can handle
        a scale factor.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::create): Take a scale factor.
        (WebKit::BackingStore::BackingStore): Store the scale factor.
        (WebKit::BackingStore::incorporateUpdate): Consider the scale factor
        when asserting the size is correct.

        * UIProcess/BackingStore.h: Add a scale factor.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Check the
        scale factor too when deciding whether to reuse a backing store.
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass in the scale
        factor when creating a backing store.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate): Take the scale factor into
        account when painting.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Put the
        scale factor into the UpdateInfo.
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
        (WebKit::DrawingAreaImpl::display): Take the scale factor into account
        when allocating the bitmap and creating a graphics context for it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.

        Rebaselining video-currentTime-set.html for Chromium due to FFmpeg update.

        * platform/chromium-mac/media/video-currentTime-set-expected.txt:
        * platform/chromium-win/media/video-currentTime-set-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Simon Fraser.

        [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
        https://bugs.webkit.org/show_bug.cgi?id=63698

        Added a test which ensures text stroke is rendered with non-zero width border.

        * platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
        * platform/chromium/fast/text/text-stroke-with-border.html: Added.
2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Simon Fraser.

        [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
        https://bugs.webkit.org/show_bug.cgi?id=63698

        Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.

        Test: platform/chromium/fast/text/text-stroke-with-border.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Update new-run-webkit-tests now that the wk2 shared skipped list has moved
        https://bugs.webkit.org/show_bug.cgi?id=63780

        The shared list was moved from mac-wk2 to wk2 as part of
        http://trac.webkit.org/changeset/90125.

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=63697

        * platform/chromium/test_expectations.txt: Some tests need new expectation images.
2011-06-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
        https://bugs.webkit.org/show_bug.cgi?id=63697

        http://trac.webkit.org/changeset/86261 added a thumb flipping code
        for Mac-WebKit2. Chromium also needs it.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium-Mac] Update test expectation files.

        * platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
        * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Removed.
        * platform/chromium-mac/fast/forms/basic-buttons-expected.png: Added.
        * platform/chromium-mac/fast/forms/button-sizes-expected.png: Added.
        * platform/chromium-mac/fast/forms/file-input-direction-expected.png:
        * platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
        * platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Added.
        * platform/chromium-mac/fast/forms/input-appearance-range-expected.png:
        * platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png:
        * platform/chromium-mac/fast/forms/slider-padding-expected.png: Removed.
        * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
        * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectation files for r90089.

        * platform/chromium-linux/fast/css/input-search-padding-expected.png:
        * platform/chromium-linux/fast/css/input-search-padding-expected.txt:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-linux/fast/forms/placeholder-set-value-expected.png: Added.
        * platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
        * platform/chromium-linux/fast/forms/search-styled-expected.txt:
        * platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
        * platform/chromium-linux/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/searchfield-heights-expected.txt.
        * platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
        * platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
        * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
        * platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
        * platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
        * platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
        * platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Removed.
        * platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
        * platform/chromium-win/fast/css/input-search-padding-expected.png:
        * platform/chromium-win/fast/css/input-search-padding-expected.txt:
        * platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
        * platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
        * platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-set-value-expected.txt:
        * platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/chromium-win/fast/forms/search-rtl-expected.txt:
        * platform/chromium-win/fast/forms/search-styled-expected.png:
        * platform/chromium-win/fast/forms/search-styled-expected.txt:
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
        * platform/chromium-win/fast/forms/searchfield-heights-expected.png: Added.
        * platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
        * platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
        * platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
        * platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png.
        * platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Adam Barth  <abarth@webkit.org>

        The win32 implementation of fork is sad about forking test-webkitpy.
        Hopefully this will heal the bot.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Hajime Morita.

        [Chromium] Remove WebBindings::makeNode.
        https://bugs.webkit.org/show_bug.cgi?id=63613

        Dead code elimination. No change in behaviour, so no new tests.

        * public/WebBindings.h:
        * src/WebBindings.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove the concept of "being wedged" from new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=63767

        Worker processes shouldn't ever become wedged.  My understanding is
        that this code was originally motivated by the old threading-based
        design but no longer servers any purpose.

        Note: If we actually have a problem with the test harness getting
        stuck, buildbot will kill us.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectations.

        * platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
        * platform/chromium-mac-leopard/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium-win-xp/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>

        Reviewed by Pavel Feldman.

        WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
        https://bugs.webkit.org/show_bug.cgi?id=40447

        * inspector/editor/text-editor-model-replace-tabs-expected.txt: Added.
        * inspector/editor/text-editor-model-replace-tabs.html: Added.
2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>

        Reviewed by Pavel Feldman.

        WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
        https://bugs.webkit.org/show_bug.cgi?id=40447

        Test: inspector/editor/text-editor-model-replace-tabs.html

        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-06-30  Kent Tamura  <tkent@chromium.org>

        [Mac][Chromium] Update test expectations for r90089

        The placeholder position changes are expected because we respect
        paddings for text fields.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
        * platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/placeholder-position-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90192.
        http://trac.webkit.org/changeset/90192
        https://bugs.webkit.org/show_bug.cgi?id=63788

        Appears to have caused NRWT on Chromium WebKit Vista to hang
        (Requested by abarth on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-07-01  Kent Tamura  <tkent@chromium.org>

        [Chromium] More test expectation update for r90089

        Need to update a Windows XP expectation because the corresponding
        chromium-win expectation was updated.

        * platform/chromium-win-xp/fast/forms/search-styled-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90212 268f45cc-cd09-0410-ab3c-d52691b4dbfc