...actually on what @ronaldbradford had added, I personally would against
doing the calculations in the check... the metrics themselves should be
measured as unadulterated as possible, and then any calculations should be
performed at the presentation layer (ie. graphing)


On Thu, Jan 23, 2014 at 5:06 PM, Seth Kingry <sjkingry@gmail.com> wrote:

> Sorry for the late reply, all of that sounds good, and yes it looks like
> 'innodb_current_row_locks' should be a gauge and not a counter
>
>
> On Thu, Jan 23, 2014 at 4:22 PM, Remi Hakim <notifications@github.com>wrote:
>
>> In checks.d/mysql.py:
>>
>> >      'Slow_queries': ('mysql.performance.slow_queries', RATE),
>> >      'Questions': ('mysql.performance.questions', RATE),
>> >      'Queries': ('mysql.performance.queries', RATE),
>> > +    'Com_select': ('mysql.performance.com_select', RATE),
>> > +    'Com_insert': ('mysql.performance.com_insert', RATE),
>> > +    'Com_update': ('mysql.performance.com_update', RATE),
>> > +    'Com_delete': ('mysql.performance.com_delete', RATE),
>> > +    'Innodb_mutex_spin_waits': ('mysql.innodb.mutex_spin_waits', RATE),
>> > +    'Innodb_mutex_spin_rounds': ('mysql.innodb.mutex_spin_rounds', RATE),
>> > +    'Innodb_mutex_os_waits': ('mysql.innodb.mutex_os_waits', RATE),
>> > +    'Created_tmp_tables': ('mysql.performance.created_tmp_tables', RATE),
>> > +    'Created_tmp_disk_tables': ('mysql.performance.created_tmp_disk_tables', RATE),
>> > +    'Created_tmp_files': ('mysql.performance.created_tmp_files', RATE),
>> > +    'Innodb_row_lock_waits': ('mysql.innodb.row_lock_waits', RATE),
>> > +    'Innodb_row_lock_time': ('mysql.innodb.row_lock_time', RATE),
>> > +    'Innodb_current_row_locks': ('mysql.innodb.current_row_locks', RATE),
>>
>> Thanks for the input @ronaldbradford <https://github.com/ronaldbradford>!
>>
>> @skingry <https://github.com/skingry> we should probably add the fields
>> @ronaldbradford <https://github.com/ronaldbradford> is talking about
>> separately.
>>
>> What do you think ?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/DataDog/dd-agent/pull/726/files#r9130361>
>> .
>>
>
>