Done!


>________________________________
> De: Nathan Woodrow <notifications@github.com>
>Para: qgis/QGIS <QGIS@noreply.github.com> 
>CC: Alvaro Huarte <ahuarte47@yahoo.es> 
>Enviado: Lunes 27 de enero de 2014 11:17
>Asunto: Re: [QGIS] Fix bug #9429: enable validation ids with optional parameter (#1116)
> 
>
>
>In src/core/qgsvectorlayer.cpp:
>>  {
>    QgsFeatureIds deselectedFeatures = mSelectedFeatureIds - ids;
>  
>    mSelectedFeatureIds = ids;
>  
> +  if ( validateIds )
> +  {
> +    QgsFeatureIds allIds;
> +    bool selectAllIds = true; 
>Having a bool check inside a while like that is a bit of a code smell to me.  Better to make it more explicit. 
>if ( validateIds && !mSelectedFeatureIds.empty() ) 
>—
>Reply to this email directly or view it on GitHub.
>
>