popup working fine