I meant to comment on this point, but forgot. +1 to renaming, and +1 to it being in a separate PR

Martin Harris
Lead Software Engineer, AgriWise Solutions
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com


> On 13 Mar 2014, at 20:58, Andrew Kennedy <notifications@github.com> wrote:
> 
> In core/src/main/java/brooklyn/location/cloud/CustomMachineNamer.java:
> 
> > +package brooklyn.location.cloud;
> > +
> > +import java.util.Map;
> > +
> > +import brooklyn.config.ConfigKey;
> > +import brooklyn.entity.Entity;
> > +import brooklyn.entity.basic.ConfigKeys;
> > +import brooklyn.entity.basic.EntityInternal;
> > +import brooklyn.util.config.ConfigBag;
> > +import brooklyn.util.text.Strings;
> > +import brooklyn.util.text.TemplateProcessor;
> > +
> > +import com.google.common.collect.ImmutableMap;
> > +import com.google.common.reflect.TypeToken;
> > +
> > +public class CustomMachineNamer extends CloudMachineNamer {
> Agree on having an interface for this, and @aledsage's comments on possible class names, and I suspect we don't have much backwards compatibility to worry about here. Should probably have been marked @Beta from the start, but maybe do this in another PR.
> 
> —
> Reply to this email directly or view it on GitHub.