TLV Redux

Alright @adamvoncorswant, feel free to take a peek when you get a moment. Never before has there been such a test-covered parser :tada: 

FYI @linnie if you're interested. EMV stuff and all that.
I'm all for skipping Javadoc entirely,or is it something we're pursuing
because it's a public library? Can't for the life of me remember when I
last saw a Javadoc that was coherent with the content, or had any useful
information...

On Mon, Dec 22, 2014 at 10:12 AM, Adam von Corswant <
notifications@github.com> wrote:
>
> In izettle-emv/src/main/java/com/izettle/tlv/TLVEncoder.java
> <https://github.com/iZettle/izettle-toolbox/pull/97#discussion-diff-22158760>
> :
>
> > +
> > +import static com.izettle.java.ValueChecks.*;
> > +
> > +/**
> > + * ISO 7816 / ASN.1 compliantish encoder.
> > + * @author fidde
> > + */
> > +public class TLVEncoder {
> > +
> > +	public TLVEncoder() { }
> > +
> > +	/**
> > +	 * Validates tag and creates a properly encoded length.
> > +	 * @param tag Tag bytes
> > +	 * @param value Data bytes, nullable.
> > +	 * @throws TLVException On malformed inputs
>
> Nitpicking: My editor warns me about incomplete javadocs (missing return
> tag). As this is open code, I believe that we should try making it perfect
> :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/iZettle/izettle-toolbox/pull/97/files#r22158760>.
>