Remove unused "commit message edited" mail sender and template

A regular "new patch set" notification email is sent when the
commit message is edited.

Change-Id: Ia6f679587219e3c45d8d3f680c0708fcb3f6b17c
Acceptance test: Add support to make plain HTTP requests

Change-Id: I065da5387996f53da8ddddc7e0fb2f1314b04fbf
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
SideBySide2: Bind shift-space to page up

Space goes page down, shift-space usually goes page up
in a browser. Match that expected default behavior.

Change-Id: I79288e16c53c2690c507022d4560c84dfdbbb91c
SideBySide2: Make page up/down respect visible lines

Remap PageDown/PageUp, Ctrl-f/Ctrl-b, and Space/Shift-Space
to Ctrl-d/u. This uses moveByScroll instead of moveByPage.

The moveByScroll vim function works off visible display lines,
which prevents CM3 from entering into the first skipped region
when paging up to the start of the file.

Unfortunately this does not fix paging at the end of the file,
CM3 still enters the skipped region and expands the final lines
during page down.

Change-Id: I99aa9097ff86e86558fea6f80bf81ba41db424ab
Revert "Include trailing newline in last skip."

This reverts commit a76cc7223f112494702b2cb13c9c1ae65b153d68.
Leave the last line of the file outside of the skip region so
page down has somewhere to land without entering and expanding
the tail of the file.

Change-Id: Ib9c1d5d3948d3f32b7e7ad5696e6ad6d09000ca6
Normalize approvals when submitting instead of when merging

If we normalize approvals at merge time, there is a potentially long
race period between the submit rule evaluator being run (only once, at
submit time) and the change being merged. During this period,
permissions can change in such a way that the change would no longer
be submittable, but the submit rule evaluator is not checked again at
merge time.

Instead, normalize approvals at submit time. It is still possible that
the normalized values for a submitted/merged change would not make
sense given a later state of the label configuration, e.g. if a label
range is increased. But at least we are now consistent (up to a much
shorter race window during submit, at least) with the state when the
submit rule evaluator was run.

To simplify the code, this change also removes the behavior whereby
approvals that were normalized to 0 are deleted entirely, leaving only
the ChangeMessage to indicate that a user was ever a reviewer. This
changes results in some corner cases in ways that should mostly be
acceptable. For example, if a user voted on a change but then lost
permissions before submit time, ChangeJson will now be able to report
them as a reviewer (who didn't vote), which it would not have done if
all PatchSetApprovals for that user were deleted. That said, this is
just to justify that this behavior is not a serious regression; in the
medium term we will be removing the PatchSetApprovals table in favor
of the much saner notedb implementation.

Change-Id: I143a5a890e59461c9f9e348c10d1d16996d95c1b
Codemirror: Add support for perl mode

Bug: issue 2398
Change-Id: Ie7c2b4583a71ad9646ef745df156bcb31ae1f9a4
Merge "Normalize approvals when submitting instead of when merging"
Mark LabelTypes maps volatile

Change-Id: Iab5114517985ee53a2af096aebd8222a001a37d3
SideBySide2: Replace system scrollbar with one on the overview

Draw the viewport as a semi-transparent box on top of the overview bar
on the right side of SideBySide2.  This allows the reader to see how
much of the visible file content is currently displayed.

Handle drag events on this box and translate them into scroll events
on the CM3 instances.  This allows the reader to grab the viewport
representation with the mouse and move it over another section.

Make the height of each edit insert, delete or edit region related to
the number of lines impacted.  Regions that touch more lines will take
up more vertical space on the overview bar.

Remove the scrollbar from the B CM3.  Rely on keyboard up/down, page
up/down, mouse wheel, and dragging the viewport widget placed in the
overview bar area.

Change-Id: Ica0355a4b5f4a350b2db6c8557186fbb4758a24f
Codemirror: Add support for ruby mode

Change-Id: I0077bf99ec9960beb6d40911b65ee92af523b093
Merge "SideBySide2: Replace system scrollbar with one on the overview"
Merge "Mark LabelTypes maps volatile"
Merge changes I0077bf99,Ie7c2b458

* changes:
  Codemirror: Add support for ruby mode
  Codemirror: Add support for perl mode
Documentation: Update download link

For quite some time, downloads have not been hosted on Google Code,
and are now hosted elsewhere. The documentation should reflect this
move. The one schema update on Google Code is not what most users
will be looking for when trying to download Gerrit

Change-Id: Ib1f7a9bc17e02d4cfce849a960e461425f004e91
SideBySide2: Fix click above/below viewport bubble to page up/down

Change-Id: If224ab5fb1bef729a2a7a7fb0dec137e2e8122a5
Remove quotes and trailing period from "topic edited" messages

When the topic is edited, a change message is added that shows
the old and new topics.  If the topic is set to a URL, the URL
is linkified, but the linkification includes the trailing closing
quote and period after the topic name, and the link does not work.

Remove the quotes and trailing period to prevent this.

Bug: Issue 2397
Change-Id: Ic70882f7355cf84e12a2853f0ac6a77c4ca1543d
Update searchHint

The searchHint currently displays so few of the searching capabilities
of Gerrit that it isn't very useful. Replacing it with something more
generic will make it cleaner and just as useful. There is no way to
display all of the search features in the hint

Change-Id: I7d2334adfd4a5d99fcdff4f2c37457ce8f08da3f
Merge "Acceptance test: Add support to make plain HTTP requests"
Merge "SideBySide2: Fix click above/below viewport bubble to page up/down"