Sorry, had another piece of code in mind. 




This check isn't needed. I think I added it to avoid empty length attributes, but that doesn't have much use...

On Mon, Jan 6, 2014 at 8:48 PM, hacfi <notifications@github.com> wrote:

>>      }
>>  
>> -    public function createValueNode($value, \DOMDocument $dom)
>> +    public function createValueNode($value, \DOMDocument $dom, $length)
> Why not make ``$length`` optional (`` = null``)?
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jackalope/jackalope-doctrine-dbal/pull/156/files#r8675209