refactor of sale filters