dock_set_attacheddocks removed arg type

This patch removes the dock type argument, because it was previously
set in dock->type.
set_attacheddocks removed arg type

This patch removes the dock type argument, because it was previously
set in dock->type.
set_attacheddocks_map removed arg type

This patch removes the dock type argument, because it was previously
set in dock->type.
move_to_dock function removed stuff

This patch removes some stuff in the move_to_dock function:

1. The icon is painted, when moved, always. Now, if the dock is lowered
   the icon is painted anyway. Is just what Dan pointed.

2. Some descriptors are removed. Because the icon is created, moved and
   destroyed, we don't need set these descriptors. Less code, less time.

3. We don't need paint the icon using dockIconPaint(icon). Now, the dock
   is not changed, but the behavior is good. Less code again. We don't
   need set the launching flag if we don't call dockIconPaint.

4. Added some comments.
move_to_dock does not use WDock

The function move_to_dock doesn't use the WDock struct. Because we
removed the Dan idea, we don't need the WDock now in the move_to_dock
function. We only need the WScreen argument, so we use this now.
Move the function move_to_dock to appicon.c

The function move_to_dock, renamed to move_appicon_to_dock, handles
only an appicon, so is better move it to the appicon.c file.
wDockTrackWindowLaunch remove goto

This patch creates the function find_win_in_dock and then
removes the goto.
wClipUpdateForWorkspaceChange style changes

This patch do these changes:

1. Move the variable definition to the function top.
2. Return if the preferences noclip flag is set. Then, we can remove
   tabs in the lines.
3. Include some extra empty lines.