Rolled out <http://trac.webkit.org/changeset/166184>
https://bugs.webkit.org/show_bug.cgi?id=133144

Reviewed by Gavin Barraclough.

It caused a performance regression.


../JavaScriptCore: 
* heap/BlockAllocator.cpp:
(JSC::BlockAllocator::blockFreeingThreadStartFunc):

../WTF: 
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::runScavengerThread):
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
(WTF::setCurrentThreadQOSUtility): Deleted.
* wtf/ThreadingWin.cpp:
(WTF::setCurrentThreadQOSUtility): Deleted.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WebKit2] Cleanup the build from unused variable in WebProcess module
https://bugs.webkit.org/show_bug.cgi?id=133062

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

Fix unused parameter by using UNUSED_PARAM macro

* WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeUserScriptMessageHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface
https://bugs.webkit.org/show_bug.cgi?id=124832

Reviewed by Antonio Gomes.

The original code was only calling platformMakeCurrent when the
GL_EXT_robustness extension is supported: the alternate code path
would only create a context, but it wouldn't make that context
current. This patch ensures platformMakeCurrent is also called for
the alternate code path, and, if it fails to make the context
current, will destroy the context. Effectively, this makes both
code paths behave in the same way.

* platform/graphics/surfaces/egl/EGLContext.cpp:
(WebCore::EGLOffScreenContext::initialize):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Unreviewed GTK gardening

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-05-21

* platform/gtk/TestExpectations: Report and mark new tests failing.
* platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
Rebaseline after r169048.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed EFL gardening.

* platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
Rebaseline after r169048.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=133145

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

* Scripts/run-jsc-stress-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CMake] Support building with Debug Fission
https://bugs.webkit.org/show_bug.cgi?id=131177

Reviewed by Philippe Normand.

* Source/cmake/OptionsCommon.cmake: add a DEBUG_FISSION option to enable usage
of http://gcc.gnu.org/wiki/DebugFission.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed EFL gardening

Rebaseline test expectations after r169048.

* platform/efl/css1/box_properties/float_on_text_elements-expected.txt:
* platform/efl/css1/text_properties/text_indent-expected.txt:
* platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/efl/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/efl/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
* platform/efl/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
* platform/efl/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/efl/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
* platform/efl/css2.1/t1601-c547-indent-00-b-a-expected.txt:
* platform/efl/fast/block/float/026-expected.txt:
* platform/efl/fast/block/float/028-expected.txt:
* platform/efl/fast/css/empty-pseudo-class-expected.txt:
* platform/efl/fast/css/first-child-pseudo-class-expected.txt:
* platform/efl/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/efl/fast/line-grid/line-align-left-edges-expected.txt:
* platform/efl/fast/multicol/column-count-with-rules-expected.txt:
* platform/efl/fast/multicol/float-multicol-expected.txt:
* platform/efl/fast/multicol/layers-in-multicol-expected.txt:
* platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/efl/fast/text/whitespace/024-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r169092 and r169102): Skip failing JSC tests on ARM64 properly
https://bugs.webkit.org/show_bug.cgi?id=133149

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-05-21
Reviewed by Csaba Osztrogonác.

PerformanceTests/SunSpider:
* profiler-test.yaml:

Source/JavaScriptCore:
* tests/mozilla/mozilla-tests.yaml:

LayoutTests:
* js/script-tests/function-apply-many-args.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
https://bugs.webkit.org/show_bug.cgi?id=132933

Reviewed by Darin Adler.

Source/WebCore:
Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.

Test: fast/multicol/newmulticol/table-section-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):

LayoutTests:
Added test for crash caused by invalid layout for RenderTableSection.

* fast/multicol/newmulticol/table-section-crash-expected.txt: Added.
* fast/multicol/newmulticol/table-section-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Garbage when rubber-banding at the right edge of a page zoomed to non-integral scale.
https://bugs.webkit.org/show_bug.cgi?id=133139
<rdar://problem/16503353>

Reviewed by Simon Fraser.

Do not pixel align the root content layer. The alignment code expands the graphics's layer size
which makes the right and bottom tiles bigger than the content.
Painting the body's background color produces pixel cracks, because the content can not
fill the expanded tiles completely.

Not testable.

* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::needsPixelAligment):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::computePixelAlignment):
* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::rectForTileIndex):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::needsPixelAligment):
* rendering/RenderLayerBacking.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Array.prototype.find and findIndex should skip holes
https://bugs.webkit.org/show_bug.cgi?id=132658

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:
Skip holes in the array when iterating such that callback isn't called.

* builtins/Array.prototype.js:
(find):
(findIndex):

LayoutTests:
* js/array-find-expected.txt:
* js/array-findIndex-expected.txt:
* js/script-tests/array-find.js:
* js/script-tests/array-findIndex.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r168625): [GTK] Assertion failure in LocalStorageDatabaseTracker
https://bugs.webkit.org/show_bug.cgi?id=133118

Reviewed by Philippe Normand.

Call WebContext::applyPlatformSpecificConfigurationDefaults() to
initialize the WebContextConfiguration before creating the default WebContext.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, roll out http://trac.webkit.org/changeset/169159.
        
This was a unilateral change and wasn't properly reviewed.


PerformanceTests/SunSpider: 
* profiler-test.yaml:

Source/JavaScriptCore: 
* tests/mozilla/mozilla-tests.yaml:

LayoutTests: 
* js/script-tests/function-apply-many-args.js:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CMake] Improve handling of LIB_INSTALL_DIR, EXEC_INSTALL_DIR, and LIBEXEC_INSTALL_DIR
https://bugs.webkit.org/show_bug.cgi?id=132819

Reviewed by Carlos Garcia Campos.

.:
* CMakeLists.txt: Hard-code CMAKE_ARCHIVE_OUTPUT_DIRECTORY etc, so that we can accept absolute paths for LIB_INSTALL_DIR
and friends.
* Source/cmake/OptionsCommon.cmake: Get rid of LIB_SUFFIX and try to make all path variables absolute. Also set
CMAKE_ARCHIVE_OUTPUT_DIRECTORY, etc using the last path component of LIB_INSTALL_DIR, etc, so that absolute paths
are supported.
* Source/cmake/OptionsGTK.cmake: Ditto. Also get rid of all pkg-config specific variables.

Source/JavaScriptCore:
* javascriptcoregtk.pc.in: Instead of using the special pkg-config variables,
use the common CMake ones directly.

Source/WebKit/efl:
* EWebKitConfig.cmake.in: LIB_INSTALL_DIR is always absolute now, so we don't need
to prefix it with the prefix.
* ewebkit.pc.in: Instead of hard-coding the path to the library installation directory use LIB_INSTALL_DIR.

Source/WebKit2:
* PlatformEfl.cmake: No need to prefix EXEC_INSTALL_DIR with the prefix any longer.
* PlatformGtk.cmake: No longer use CMAKE_INSTALL_FULL_FOO variables, instead using the WebKit-specific ones.
* efl/EWebKit2Config.cmake.in: Ditto.
* efl/ewebkit2.pc.in: Instead of hard-coding the path to the library installation directory use LIB_INSTALL_DIR.
* webkit2gtk-web-extension.pc.in: No longer use the pkg-config only variables. Instead use
the common CMake ones.
* webkit2gtk.pc.in: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Mac gardening after r169161.

* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Mac] REGRESSION (Async text input): Asian text input doesn't work in Flash
https://bugs.webkit.org/show_bug.cgi?id=133128
<rdar://problem/16890920>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _interpretKeyEvent:completionHandler:]): Added a separate code path for
plug-in input. Before async text input, we used to provide a nil input context due
to having _data->_interpretKeyEventsParameters while this function was executing,
and thus took a shortcut. The new behavior is different from pre-async in that
we don't collect commands at all, but I couldn't find any case where that mattered.
(-[WKView inputContext]): The _collectedKeypressCommands check was not a correct
replacement for _interpretKeyEventsParameters one, because this variable is not
always set within -_interpretKeyEvent:completionHandler:.

* UIProcess/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
While at it, fixed a separate issue with Cangjie predictive input. We shouldn't
keep prediction pop-up on screen after hiding the bottom input window.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Special handling of telephone number detection menu.
<rdar://problem/16967971> and https://bugs.webkit.org/show_bug.cgi?id=133143

Reviewed by Geoff Garen.

Add a bool to ContextMenuContextData to represent telephone number menus:
* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::operator=):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isTelephoneNumberContext):

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu): If the menu is a telephone
  number menu then display it using a specific AppKit API.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showTelephoneNumberMenu): Filter the array of menu items
  through a new WKSI call, and then show it using a telephone number context.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Turn on ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=133153

Reviewed by Gyuyoung Kim.

.:
* Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.

Source/WebKit2:
Make WebKit2 compile after r166741 when CSS_FILTERS are enabled.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):

LayoutTests:
Remove failure test expectations for tests passing after turning on CSS_FILTERS.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Actually enable snapshot tests on mac wk2.
        https://bugs.webkit.org/show_bug.cgi?id=131871

        * platform/mac-wk1/TestExpectations: Skip them here.
        * platform/mac/TestExpectations: Unskip them here.

        Some slight modifications to some of the tests to reduce flakiness of tests.
        * plugins/snapshotting/autoplay-dominant.html:
        * plugins/snapshotting/autoplay-plugin-blocked-by-image.html:
        * plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image.html:
        * plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html: 

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169173 268f45cc-cd09-0410-ab3c-d52691b4dbfc